Repository navigation
Accept only did_v2 as TargetVersion ([V_eta not kept as an alias]) - #371
Merged
Merged
Conversation
Decided by Jess Haley, 2026-11-02 [V_eta not kept as an alias] (did-schema docs/plans/did_v2_go_forward_class_audit.md): the last step of [schema set renamed did_v2]. did2.convert.isV2Set answers true for 'did_v2' only, every TargetVersion argument check names 'did_v2' only, and targetStamp no longer maps 'V_eta'. Tests that passed 'V_eta' pass 'did_v2'; testSchemaSetNames checks that 'V_eta' is refused. NDI-matlab stops accepting it first (VH-Lab/NDI-matlab#1147). Not changed: the folder fallback schemas/V_eta/<tier> in did2.schema.cache and tools/assemble_schema_set.py (an older did-schema checkout's folder), and the refusal of a document stamped 'V_eta' ([V_eta stamp not accepted]). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
November 2, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the DID-matlab half of [V_eta not kept as an alias] (Decided by Jess Haley, 2026-11-02, did-schema
docs/plans/did_v2_go_forward_class_audit.md): the last step of [schema set renamed did_v2]; onlydid_v2is accepted asTargetVersion.Merge after VH-Lab/NDI-matlab#1147 (NDI stops accepting and passing
V_eta; NDI CI reads DID-matlabV2live).Change
did2.convert.isV2Set: true for'did_v2'only.TargetVersionargument check ofv1_to_v2and the ten batch passes (epochMint,foldGenericFiles,resolveClockAlignment,resolveDatasetEntities,resolveDeferredBaths,resolveEpochProbemap,resolveOpenmindsCitations,resolveResponseParameters,resolveSessionAnchors,resolveValidIntervals):{'did_v2'}.did2.convert.targetStamp: no longer maps'V_eta'to the stamp.testSchemaSetNameschecks thatV_etais refused (argument error) and is not the V2 set;testDocumentStamps,testV1ToV2Audits,testRawV1RoundTripGene,testWholeBatchRoundTrippassdid_v2.V_etaleft in DID-matlab (not an acceptedTargetVersion)did2.schema.cacheandtools/assemble_schema_set.py: the folder fallbackschemas/V_eta/<tier>for an older did-schema checkout (a folder name;testSchemaSetNamesstill covers it).v1_to_v2refuseUnknownSchemaVersion: a document stampedV_etais refused ([V_eta stamp not accepted]);testDocumentStampskeeps those refusal checks.V_eta_corpus_proofartifact fallback intest-corpus.yml, and history/decision-tag comments.Generated by Claude Code