Repository navigation
testJsonRoundTrip: drive rehydrate through coordinate_system.axes, not acquisition_channels - #370
Merged
Conversation
The five rehydrate tests built a blank `acquisition_channels` behind a
`hasClass` guard that assumeFails when the class is absent. did-schema is
retiring that class (Jess Haley 2026-11-01 [probe wiring is a relation],
did_v2_go_forward_class_audit.md), and on that day the five tests would
have become Incomplete: silent no-ops, not failures.
They now drive `coordinate_system.axes`, a persist class whose field is a
non-scalar `structure` with plain subfields {axis, positive_direction,
spacing}. A schema set without coordinate_system is an assertion failure,
not an assumption.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
November 2, 2026 05:54
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## V2 #370 +/- ##
=========================
=========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Siblings first for did-schema's retirement of
acquisition_channels(Jess Haley 2026-11-01 [probe wiring is a relation],did_v2_go_forward_class_audit.md).Five rehydrate tests in
tests/+did2/+unittest/testJsonRoundTrip.mbuilt a blankacquisition_channelsbehindif ~cache.hasClass('acquisition_channels'), assumeFail(...). Once did-schemamaindrops the class, those five would turn Incomplete, which means they would stop testing anything without failing.This PR moves them to
coordinate_system.axes, a non-scalarstructurewith plain subfields {axis, positive_direction, spacing} on a class marked persist. Ifcoordinate_systemis missing, the test now fails on anassertTrueinstead of being skipped by an assumption.Test-only change. It does not touch migration files.
Generated by Claude Code