Repository navigation
testBatchPassWiring: divergence row for NDI's v1FileReader - #368
Merged
Merged
Conversation
NDI-matlab #1140 added ndi.migrate.internal.v1FileReader, which ndi.migrate.local passes to pass 1 so a migrator can read a v1 document's attached file (gene_list_mapping's mapping.tsv, [gene list mapping is built]). It runs on the NDI side only: it reads NDI's own file store (<.ndi>/files/<uid>, ndi.migrate.internal.v1AttachedFile), which DID-matlab does not have. testCrossRepoDivergenceIsExactlyTheCheckedInTable failed on V2 for want of this row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
…he code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
November 2, 2026 02:50
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## V2 #368 +/- ##
=========================
=========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failure on DID-matlab
V25c6f3c3 indid2.unittest.testBatchPassWiring/testCrossRepoDivergenceIsExactlyTheCheckedInTable: "v1FileReader runs on the NDI side ONLY".NDI-matlab #1140 added
ndi.migrate.internal.v1FileReader.ndi.migrate.localpasses it to pass 1 as theV1FileReaderoption, so a migrator can read a v1 document's attached file (first:gene_list_mapping'smapping.tsv, [gene list mapping is built], Jess Haley 2026-10-31). It runs on the NDI side only because it reads that file from NDI's own file store (<.ndi>/files/<uid>,ndi.migrate.internal.v1AttachedFile), which DID-matlab does not have. This PR adds thecrossRepoDivergenceTablerow saying so. Test-only.Generated by Claude Code