Repository navigation
testStrandedSourceTombstones: read no generic_file schema file - #366
Merged
Merged
Conversation
The one DID-matlab read of did-schema's retiring/generic_file.json was
testGenericFileHasASchemaAtAll (cache.getClass('generic_file')). Since
DID-matlab #351, pass 1 hands a v1 generic_file on as v1 to
foldGenericFiles, checked against NDI's template and never validated
against V2 ([ensemble and generic_file checked as v1], Jess Haley,
2026-11-01). The test now asserts that: handed on, unquarantined, did_v1.
This lets did-schema delete retiring/generic_file.json and
retiring/ensemble.json, as that decision says.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
November 2, 2026 03:11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## V2 #366 +/- ##
=========================
=========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets did-schema build its part of [ensemble and generic_file checked as v1] (Decided by Jess Haley, 2026-11-01, did-schema
docs/plans/did_v2_go_forward_class_audit.md): "their renamed-spellingretiring/files are deleted". Its tail on did-schema main:Build pending: did-schema (delete retiring/ensemble.json and retiring/generic_file.json once DID-matlab no longer reads them).What still read them
git grepon DID-matlabV25c6f3c3 for a read of either file by class (getClass,hasClass,schemaHasClass, theretiring/path):tests/+did2/+unittest/testStrandedSourceTombstones.mtestGenericFileHasASchemaAtAll:cache.getClass('generic_file'). The only hit.ensemble's schema.v1_to_v2asksgetClass(className)for a carried or handed-on document only to COUNT it inpassthrough_unvalidated_no_schemawhen no V2 class exists. After the deletion, anensembleorgeneric_fileis counted there too. No test asserts an exact value for that counter on these classes (the two assertions, intestFixtureCorpusandtestNgridCoordinates, are>= 1/isfieldfor other classes).Change
testGenericFileHasASchemaAtAllbecomestestGenericFileHasSomewhereToGo. It reads no schema file and asserts what holds since #351: pass 1 hands a v1generic_fileon, unquarantined, stampeddid_v1(bodies_handed_to_later_step1). Thevalid_intervalhalf is unchanged.Test-only. No migration behaviour changes.
Not run locally (no MATLAB here). CI is the first run.
Generated by Claude Code