Repository navigation
undirected_relation: write and read relatum_id only (drop entity_id) - #365
Merged
Merged
Conversation
Builds the last step of [undirected ends are relata] (Jess Haley, 2026-11-01, did-schema did_v2_go_forward_class_audit.md): the code read both names (#338), did-schema renamed the edge (main declares only relatum_id), and now the code drops entity_id. - did2.build.undirectedRelation writes relatum_id always; the schema probe for the old name is gone. - did2.build.relatumIds reads relatum_id edges only. - testBuild: the builder writes relatum_id only and the schema in use declares relatum_id and not entity_id; an entity_id edge is not an end. - geneMappingSchema no longer rewrites undirected_relation (did-schema declares relatum_id). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
November 2, 2026 03:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## V2 #365 +/- ##
=========================
=========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jesshaley
pushed a commit
to Waltham-Data-Science/DID-schema
that referenced
this pull request
Nov 2, 2026
- [ndi_document read as base], [rename clashes are malformed]: the second-pass readers read raw v1, NDI-matlab c648e3d1 (#1144). - [fields outside the template are malformed]: second-pass carries of an off-template field cite carry-100, NDI-matlab c648e3d1 (#1144). - [ensemble and generic_file keep their conversions]: ensembleMembership reads the raw v1 map, NDI-matlab fdeb77a1 (#1143). - [undirected ends are relata]: NDI-matlab drops entity_id, 646f4c0f (#1142); DID-matlab stays pending on VH-Lab/DID-matlab#365. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the DID-matlab part of [undirected ends are relata] (Decided by Jess Haley, 2026-11-01, did-schema
docs/plans/did_v2_go_forward_class_audit.md): "undirected_relation.entity_idis renamedrelatum_id. ... DID-matlab and NDI-matlab read both names and write the one the schema declares first, then the schema renames it, then the code dropsentity_id." Its tail on did-schema main:Build pending: DID-matlab, NDI-matlab (drop entity_id).did-schema main declares only
relatum_idonschemas/did_v2/relation/undirected_relation.json(itsdepends_onhas one entry,relatum_id).Changes
did2.build.undirectedRelationwritesrelatum_idalways. The schema probe that fell back toentity_idis deleted.did2.build.relatumIdsreadsrelatum_idedges only. Anentity_idedge is not an end.testBuild: the builder writesrelatum_idonly, and the loaded schema declaresrelatum_idand notentity_id.relatumIdsreads noentity_idedge.tests/+did2/+unittest/+helpers/geneMappingSchema.mno longer rewritesundirected_relation.json(did-schema declaresrelatum_id).+migrators_j/gene_list_mapping.m. No migration behaviour changes: on did-schema main the builder already wroterelatum_id.The NDI-matlab part is a separate PR (NDI-matlab
claude/relata-only).Not run locally (no MATLAB here). CI is the first run.
Generated by Claude Code