Repository navigation
Tests follow did-schema #236: text channel bound ahead of the map; lick spout registered - #297
Merged
Merged
Conversation
…ck spout registered did-schema #236 (merged d5c83628) binds EMPTY:0000410 "text channel" beside NCIT Text ([text channel replaces NCIT Text]; NDI's +vintage/channelTypes.m moves first, then channelType), and registers EMPTY:0000414 "lick spout" ([device kinds minted]), which #294 finds from the v1 type 'lick-spout'. That turned V2 red in testChannelType/testTheTenTypesAreTheSchemasBoundSet (10 vs 11 bound) and testMigratorsJRecordingObservation/ testUnmappedTypeIsFlaggedQueryablyAndKeepsObserves ('lick spout' vs 'lick-spout'). No code change: the map keeps NCIT Text for tx until NDI reads the new node; the Guard A flag and its no-observation behaviour are unchanged, only the flag's term is now the registered one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two DID-matlab tests on
V2went red after Waltham-Data-Science/DID-schema#236 merged (d5c83628) together with DID-matlab #294. I caused this: #236 changed a list these tests pin, without updating them first. This PR fixes the tests only.testChannelType/testTheTenTypesAreTheSchemasBoundSetexpected 10 bound types but found 11. SQLite search: 'hasmember' puts a text value into the SQL unquoted (errors, wrong results, SQL injection) #236 binds EMPTY:0000410 "text channel" beside NCIT Text, per [text channel replaces NCIT Text]. The writers move in order: first NDI's+vintage/channelTypes.m, which today mapstxonly to NCIT:C25704, thendid2.convert.channelType. So the test now allows "text channel" to be bound ahead of the map. Once the map writes it and NCIT Text leaves the list, the comparison is exact again.testMigratorsJRecordingObservation/testUnmappedTypeIsFlaggedQueryablyAndKeepsObservesexpectedlick-spoutbut gotlick spout. SQLite search: 'hasmember' puts a text value into the SQL unquoted (errors, wrong results, SQL injection) #236 registers EMPTY:0000414 "lick spout" ([device kinds minted]), and Find a registry term by its name ignoring case, spaces, underscores and hyphens #294 finds it from the v1 typelick-spout([term names match ignoring spacing]). The Guard A behaviour is unchanged: the modality is still flagged as unresolved and no observation is emitted. Only the flag's term is now the registered one.No source code changes. This unblocks #295 and #296, whose only other failures are these two.
Generated by Claude Code