Repository navigation
testMigratorsJ: an openMINDS id that does not rebuild, now that C. elegans's does - #292
Merged
Merged
Conversation
…egans's does did-schema #231 recorded openminds:species/caenorhabditisElegans as NCBITaxon:6239's equivalent ([species text is the openMINDS equivalent], Jess Haley, 2026-10-29). The fixture of testAnOpenmindsIdThatDoesNotRebuildIsCarried used exactly that id, so it now rebuilds and the document converts (Quick migrator tests run 40917656427: 0 passthroughs, 1 expected). The fixture keeps the NCBITaxon:6239 term and names an id with no recorded equivalent, which is the case the test is about. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
October 29, 2026 17:51
jesshaley
pushed a commit
that referenced
this pull request
Oct 29, 2026
jesshaley
pushed a commit
that referenced
this pull request
Oct 29, 2026
jesshaley
pushed a commit
that referenced
this pull request
Oct 29, 2026
jesshaley
pushed a commit
that referenced
this pull request
Oct 29, 2026
jesshaley
pushed a commit
that referenced
this pull request
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a test that has failed against did-schema
mainsince Waltham-Data-Science/DID-schema#231 merged.What changed upstream. #231 records
openminds:species/caenorhabditisElegansas NCBITaxon:6239's equivalent ([species text is the openMINDS equivalent], Jess Haley, 2026-10-29). So under [openMINDS subject leftovers], that openMINDS id now rebuilds, and the document converts instead of being carried.What failed.
testAnOpenmindsIdThatDoesNotRebuildIsCarriedused exactly that id as its example of an id that does not rebuild. Quick migrator tests run 40917656427 reported 0 passthroughs where it expected 1.Fix. The fixture keeps the NCBITaxon:6239 term but names an openMINDS id that has no recorded equivalent, which is the case the test is about. Nothing else changes.
The branch name matches did-schema's working branch, so its quick tests read that branch, which holds #231 plus the retire-class deletions in Waltham-Data-Science/DID-schema#233.
Generated by Claude Code