Repository navigation
testBuild: tighten an existing coordinate_system_id declaration instead of adding a second - #290
Merged
Merged
Conversation
…ad of adding a second testADeclaredCoordinateSystemEdgeIsReadFromTheSchema inserted a required coordinate_system_id into a copy of statement.json. Against did-schema #231, which declares the edge (optional, [site frame is a coordinate system]), the copy then held two declarations. did2.build took the later, optional one and raised no did2:build:missingEdge; the validator, which unions required edges, raised did2:validation:emptyRequiredDependency (Quick migrator tests run 40892458228 on that schema). When the schema already declares the edge, the test now sets that declaration's mustBeNonEmpty to true; otherwise it inserts as before. The assertions are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
October 29, 2026 16:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## V2 #290 +/- ##
=========================
=========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
testADeclaredCoordinateSystemEdgeIsReadFromTheSchemapass both before and after did-schema declares the edge. It has to merge before Waltham-Data-Science/DID-schema#231 (siblings first).What failed. The test simulated "did-schema has declared
coordinate_system_id" by inserting a required declaration into a copy ofstatement.json. did-schema #231 really declares it, as optional ([site frame is a coordinate system]), so against #231 the copy held two declarations:did2.buildtook the later, optional one and raised nodid2:build:missingEdge;did2:validation:emptyRequiredDependency.This failed Quick migrator tests run 40892458228 against #231's schema.
Fix. When the schema already declares the edge, the test sets that declaration's
mustBeNonEmptyto true. Otherwise it inserts a required declaration, as before. The assertions are unchanged.The branch name matches #231's, so its quick tests read #231's schema.
test-code.ymlreads did-schemamain, where the edge is not yet declared. Together they cover both states.Generated by Claude Code