Repository navigation
Drop the retired carry-054 token from two comments - #286
Merged
Merged
Conversation
did-schema #229 deletes register row carry-054 (retired rows are deleted, as 076-079 and 082 were). Two comments still named it as history, which tools/check_carry_citations.py rule R1 reads as a citation of a missing row. The wording keeps the history without the token. Passes against did-schema main (row present) and the #229 branch (row deleted). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
October 29, 2026 06:25
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## V2 #286 +/- ##
=========================
=========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did-schema Waltham-Data-Science/DID-schema#229 deletes carry register row
carry-054, which DID-matlab #278 retired. Retired rows are deleted from the register (076–079 and 082 were also deleted). Two comments still mention the row as history:metadata_editor.m:122testMigratorsJ.m:2984tools/check_carry_citations.pyrule R1 treats anycarry-NNNtoken as a citation. Once #229 merges, R1 would fail on V2. This PR rewords both comments so they keep the history without the token. It has to merge before did-schema #229 (siblings first).Checked:
check_carry_citations.pyandtest_check_carry_citations.py(19 tests, 0 failures) pass against did-schemamain(row present) and against the #229 branch (row deleted). The PR changes comments only.Generated by Claude Code