[stevevanhooser]

MATLAB counterpart of VH-Lab/DID-python#100 / #103.

Problem

Building a query in a loop with q = q | did.query(...) nests one 'or' inside another for every term. Two places walked that nesting by calling themselves once per level. A few hundred terms therefore hit MATLAB's recursion limit (500 by default) before anything was matched:

• did.database/search_doc_ids, for an OR that isn't all base.id lookups. ORed base.id lookups already avoid recursion since sqlitedb: make id, isa and regexp searches fast (doc_data search indexes, restricted AND terms) #229.
• did.datastructures.fieldsearch, case 'or'.

did.query/to_searchstructure doesn't recurse into ORs, so it needed no change.

Change

• New did.datastructures.orOperands. It flattens a chain of nested ORs into a list of operands, in left-to-right order, using an explicit stack. A nested negated OR (~or) stays a single operand, because its negation applies to its whole result.
• search_doc_ids and fieldsearch now loop over those operands instead of recursing.
• fieldsearch error check: it still raises an error when an operand isn't a structure, and now also for nested operands.
• fieldsearch stops early: it returns at the first operand that matches. The old | evaluated both sides.

Tests

TestDeepOr uses chains of 3 × the recursion limit (1,500 terms), built in a loop. It checks:

• a search with an OR of other terms;
• the same OR ANDed with a number range;
• an OR of base.id lookups;
• fieldsearch returning true and returning false;
• orOperands' order and its handling of a nested ~or, plus fieldsearch on not(c or d).

Not run here: this environment has no MATLAB.

DID-python

VH-Lab/DID-python#103 makes the same change. Its bridge entries point at 0de9cf2 here:

• a new entry orOperands ↔ or_operands;
• the fieldsearch entry;
• the database entry.

Please merge this PR first, with a merge commit as before.

---

Generated by Claude Code

[github-actions]

Test Results

455 tests  +5   455 ✅ +5   2m 32s ⏱️ +48s
 40 suites +1     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0de9cf2. ± Comparison against base commit e4a4287.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.41%. Comparing base (e4a4287) to head (0de9cf2).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   66.29%   66.41%   +0.11%     
==========================================
  Files          66       67       +1     
  Lines        4694     4710      +16     
==========================================
+ Hits         3112     3128      +16     
  Misses       1582     1582              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.