Keep artifact deletion optimistic across navigation - #1901
Open
baggiiiie wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
the ci failures are outside of this PR's diff, details:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep artifact deletion optimistic across navigation (redirection back to artifact page after deleting an artifact), so deleted cards do not appear after redirection
before
deletion-before-fix.mp4
after
artifact-delete-after.mp4
Linked issue
no issue open yet, will open one if preferred
Verification
bun run format:checkbun run lintbun run typecheckbun run testArtifacts · renaming and deleting in the console is what the agent sees next— recordingChecklist
bun run changeset), or this change needs none.