Fix HubSpot optional scopes for workspace OAuth - #1898
Open
LloydVickeryASI wants to merge 1 commit into
Open
Conversation
Author
|
CI note: the only failing check is cloud E2E shard 13. Its failure is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optional_scopeauthorize parameter for workspace-owned OAuth clientsWhy
The first-party HubSpot client already emits
optional_scope, but workspace-owned HubSpot clients only receive generic provider extras. Their generated authorization URL therefore includes requiredscopevalues while silently omitting the app's optional scopes.HubSpot requires optional app scopes in its provider-specific
optional_scopeparameter so accounts without a corresponding product can still complete consent.Test plan
bun run --cwd packages/core/sdk test -- oauth-helpers.test.ts(78 passed)bun run --cwd apps/cloud test -- src/engine/first-party-oauth-clients.test.ts(6 passed)bun run format:checkbun run lintbun run typecheck