fix(mcp): bound discovery connection teardown - #1878
Open
aryasaatvik wants to merge 3 commits into
Open
Conversation
Discovery cleanup runs in an interruption-masked finalizer. Bound an unresponsive transport close so a completed tool listing cannot strand health checks or other callers indefinitely.
aryasaatvik
marked this pull request as ready for review
August 30, 2026 09:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound MCP discovery teardown so a transport whose
close()never settles cannot strand an otherwise completed catalog refresh or health check.The close timeout matches the invocation connection pool's teardown bound. Teardown remains best-effort and a successful discovery result is preserved.
Validation
bunx vitest run src/sdk/discover-close.test.ts --reporter=dotbun run typecheckbunx oxlint -c ../../../.oxlintrc.jsonc src/sdk/discover.ts src/sdk/discover-close.test.ts --deny-warningsbunx vitest run --reporter=dot(296 passed, 29 skipped)