Measure execute result size once per result object - #1866
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | f835495 | Commit Preview URL Branch Preview URL |
Aug 30 2026, 02:32 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | f835495 | Aug 30 2026, 02:33 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The span size probe serializes the whole returned value to count its characters. The same result object was walked again for every extra span it was stamped onto: an operator-approved (autoApprove) run paid two identical size walks (inner inline span plus outer pausable span), and each retried resume that replays a settled outcome paid another. The measurement record is now cached per result object, so a large result pays one size walk total.
Walks a large result paid between engine completion and response, before vs after:
The remaining two walks on the plain path serialize to different strings by design: the size metric is a compact JSON length, the text preview is pretty-printed with indent 2. Neither can be derived from the other, so they cannot be collapsed without changing span attributes or response bytes. The suspected duplicate in the MCP host (toMcpOutputResult vs toMcpResult) is not real: the two formatting calls are mutually exclusive branches, and a test now pins that the host renders the result exactly once with or without emit() output.
Response text, structured content, truncation behavior, and span attribute values are byte-identical; tests pin the preview format (including non-ASCII and truncation) and assert walk counts via an instrumented fixture.