Cache 1Password resolutions and unblock the op spawn - #1860
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | e3805a6 | Commit Preview URL Branch Preview URL |
Aug 29 2026, 11:51 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | e3805a6 | Aug 29 2026, 11:52 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The executor resolves a connection's credential on every tool call. For 1Password-backed connections each resolution shelled out to
op— roughly a second per call under desktop-app auth — so every tool call paid that on top of the real API latency. The spawn was also synchronous with no timeout, so one stuckop(for example waiting on an approval prompt) froze the whole local server for every other request.Scoped to the 1Password plugin; other credential providers are unchanged.
secretCacheTtlMs). The cache keys by a config fingerprint, so editing or removing an account drops every cached secret at once. Not-found, ambiguity, and failures are never retained. Concurrent resolutions of one ref share one backend read even at TTL 0.opnow runs as an async spawn with a hard deadline (the existingtimeoutMs), replacing the sync op-js backend. Auth travels per spawn: service-account token via child env, desktop account via--account. This also removes op-js's process-global token state (previously worked around in Clear the 1Password service-account token from the op-js global after each call #1574).Measured on a local instance calling a loopback API (1ms direct), identical tool call, only the secret's provider differing:
/api/healthduring a 1Password resolveUnit tests cover the cache TTL/expiry/invalidation semantics and the new CLI backend (auth routing, timeout mapping, token redaction, SDK fallback).