fix(oauth): clamp client ownership on single-workspace hosts - #1854
Closed
Adityakk9031 wants to merge 1 commit into
Closed
fix(oauth): clamp client ownership on single-workspace hosts#1854Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
Contributor
Author
|
@RhysSullivan Hey, I noticed the six PRs were closed without any comments, so I wanted to understand what I should change for future contributions. Were the changes not aligned with the project's current direction, or is there a contribution process I should follow before opening PRs? I’d appreciate any feedback so I can avoid submitting changes that aren't useful to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On single-workspace hosts (local/desktop), all connections are org-scoped (
LOCAL_CONNECTION_OWNER = "org"). Previously,oauth.clients.create,oauth.clients.registerDynamic, andoauth.createClientacceptedowner: "user"clients, but those clients were categorically unusable because local connections were org-scoped and the cross-owner guard rejected them with cloud-specific wording ("A Workspace connection must use a Workspace app.").This PR:
singleWorkspace?: booleantoExecutorConfig(defaulting to true whensubject === "local"or explicitly set).owner: "user"toowner: "org"increateClient,registerDynamicClient, and core tools (oauth.clients.create,oauth.clients.registerDynamic,oauth.clients.createHandoff,oauth.clients.remove) on single-workspace hosts.packages/core/sdk/src/oauth-flow.test.tsandpackages/core/sdk/src/executor.test.ts.Closes #1850.