Deflake dialog outside-dismiss scenario - #1847
Merged
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 26e20c3 | Commit Preview URL Branch Preview URL |
Aug 29 2026, 08:13 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 26e20c3 | Aug 29 2026, 08:14 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
August 29, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario failed its last step on every selfhost CI run since the merge (main and four PR branches, all at the same assertion): the field-free revoke confirm stayed open after the outside click, and the detach wait timed out.
The trace from a failing run shows the click was dispatched 2ms after the dialog reported visible, and the DOM afterwards is byte-identical — the pointerdown was never seen by anything. "Visible" is not "listening": Radix arms outside-pointerdown dismissal via a document listener attached in a passive effect plus a 0ms timer after the content mounts. At the click moment the body already carried the modal scroll lock (the effect flush had run), so only that timer was pending; a busy renderer services injected input ahead of pending timers, and a pre-arming pointerdown simply vanishes. The test clicked once, so a missed click meant open forever. The keep-open steps could also pass vacuously the same way.
The fix synchronizes instead of sleeping: wait for the modal scroll lock (proves the arming timer is queued), then one 0ms timer round-trip through the page (same-source timers are FIFO, so the arming timer has fired), then click. Applies to all three outside clicks, which also makes the keep-open assertions provably non-vacuous. Assertions unchanged.
Not reproducible on an idle 18-core machine after 40+ attempts, including CPU throttling and saturation — the inversion needs a backlogged renderer main thread. An instrumented run that timestamps listener attachment confirmed the synchronization orders every click after arming (30/30 under saturation). Fixed scenario 10x green, plus 5x green under CPU saturation. Test-only change.