Deflake concurrent health-check coalescing tests - #1844
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 1b43089 | Commit Preview URL Branch Preview URL |
Aug 29 2026, 07:13 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 1b43089 | Aug 29 2026, 07:13 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
August 29, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three concurrent-coalescing tests in
connections.test.tsforked their checks, slept 25ms of wall time, and then asserted how many probe or credential resolutions had started. Under parallel suite load the forked fibers can still be inside their row loads when the timer fires, so the counter reads 0 where 1 (or 2) is expected. The sleep was a timing assumption, not a synchronization point. Reproduced locally: 4 of 20 runs of the old test failed with "expected +0 to be 1" under CPU saturation.The fix makes the ordering explicit. Each gated provider/probe now completes an
enteredDeferred on entry, right after it bumps the counter, and the test awaits that Deferred instead of sleeping. For the two-tenant gate-key test, the Deferred completes when the second probe arrives, so the await is the "both probes started" point; a collided gate never completes it and fails the test by timeout.Assertions are unchanged: exactly one resolution (or two distinct probes), all concurrent callers served, zero plugin probes on the credential-only path. Test-only change.
Verified: connections suite 10x consecutively green, full sdk suite green, fixed tests green 12/12 under the same CPU load that flipped the old ones.