Bound tools reads' wait on stale catalog rebuilds - #1824
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 73591ca | Commit Preview URL Branch Preview URL |
Aug 28 2026, 09:29 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 73591ca | Aug 28 2026, 09:30 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tools read (
/api/tools,tools.search,tools.describe) rebuilds every stale connection catalog before answering. The read waited for all rebuilds, so one slow or unreachable MCP server gated every catalog read behind its network timeout — listings took tens of seconds while healthy connections sat ready.A read now waits at most a grace budget (
toolsSyncGraceMs, default 2s), then answers from the persisted catalog. Rebuilds keep running detached and land on a later read. On Workers, the newHostConfig.waitUntilseam (fed by the ambientwaitUntilfromcloudflare:workers) keeps those rebuilds alive past the response, so the catalog still converges.toolsSyncGraceMs: nullrestores the strict blocking behavior; the stale-refresh concurrency test uses it, since its assertions synchronize on the read completing after every rebuild.Verified: sdk + api + plugin-mcp unit suites, and the
api-tools/mcp-catalog-synce2e scenarios on both the selfhost and cloud projects. New e2e-style test covers the grace path: a parked upstream listing no longer blocks the read, and the catalog converges once the server answers.