Skip to content

e2e: cover emit() content blocks on self-host - #1820

Merged
RhysSullivan merged 1 commit into
mainfrom
issue-1592
Aug 28, 2026
Merged

e2e: cover emit() content blocks on self-host#1820
RhysSullivan merged 1 commit into
mainfrom
issue-1592

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Fixes #1592

A self-hosted user reported that calling emit() inside execute counts the
emitted items in the result envelope, but no content actually reaches the MCP
client — only console logs and the return value came through.

I added a self-host e2e scenario that emits a plain string, a ToolFile, and a
structured object, then asserts on the actual JSON-RPC tool result's
content array (not just the emitted count). Ran it narrowly against a
real self-host MCP server and it passes: all three emitted items show up as
content blocks, matching the same code path cloud already exercises.

Since the scenario passes on main, this looks client-side rather than a
server regression — the PR is the added coverage as evidence, not a server
change.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing de81e19 Commit Preview URL

Branch Preview URL
Aug 28 2026, 09:09 AM

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud de81e19 Aug 28 2026, 09:10 AM

@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1820

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1820

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1820

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1820

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1820

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1820

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1820

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1820

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1820

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1820

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1820

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1820

executor

npm i https://pkg.pr.new/executor@1820

commit: de81e19

@RhysSullivan
RhysSullivan marked this pull request as ready for review August 28, 2026 18:28
@RhysSullivan
RhysSullivan merged commit 2168029 into main Aug 28, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emit() counts items but no content reaches the MCP client

1 participant