Drop platform resets reported by the Durable Object instrumentation - #1796
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | a175ea6 | Commit Preview URL Branch Preview URL |
Aug 28 2026, 01:38 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | a175ea6 | Aug 28 2026, 01:40 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
August 28, 2026 02:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every deploy files a small burst of error reports that mean nothing. The Cloudflare runtime resets every live Durable Object when a new script rolls out, and the Sentry DO instrumentation (
instrumentDurableObjectWithSentry) captures that reset from inside the object being torn down, with mechanismauto.faas.cloudflare.durable_objectand the runtime's message "Durable Object reset because its code was updated."The capture-owner scheme cannot reach these. It drops the instrumentation's echo only when a worker seam classified the failure, answered the client and claimed the cause — and inside a dying object there is no seam and no request to claim it. The client-facing half is already handled: the in-flight request fails at the worker seam and is rendered there as a retryable 503.
Fix
The cloud
beforeSendnow drops an event when both hold:classifyDurableObjectError, so this can never recognize a different set of messages than the worker seams do.Everything the classifier does not recognize is kept, so a real defect thrown inside a DO — an alarm crash, a broken handler, the memory-limit reset the classifier deliberately excludes — still reports.
session_deadis also kept: that disposition means our own code calledctx.abort, which is the application acting, not the platform. Worker-seam behaviour is unchanged.Testing
Unit tests in the cloud observability suite: a code-update reset with the DO instrumentation mechanism is dropped (as are the other transient kinds the classifier knows), the same message on a non-DO mechanism is kept, and an unclassified DO-side failure is kept. One existing case that used the reset message to stand for "unclaimed DO failure" now uses a real defect message, which is what it was there to express.
This layer is unreachable black-box: the dropped event and the events kept beside it declare the same exception type and shape, and only the mechanism the Sentry SDK stamps separates them, so unit tests over the hook are the only place it can be pinned.
Mutation-checked: with the drop neutralized, only the three new drop tests fail.
bun run typecheckgreenapps/cloudobservability suite green (19 tests)e2e/cloud/sentry-otel-correlation.test.tsgreen