Unlist the built-in Google OAuth app from connect pickers - #1795
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 76296e6 | Commit Preview URL Branch Preview URL |
Aug 28 2026, 01:48 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 76296e6 | Aug 28 2026, 01:48 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
unlist-google-first-party-app
branch
from
August 28, 2026 01:45
8d7c7f5 to
76296e6
Compare
RhysSullivan
marked this pull request as ready for review
August 28, 2026 01:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops offering the Executor-owned Google OAuth app for new connections, without disturbing the connections already using it.
How
FirstPartyOAuthClientConfiggains anunlistedflag, and cloud sets it on the Google entry.listClientswithholds unlisted apps — that is the only behavioural change, and it is the right single chokepoint, because listing is what offers an app for a new connection:listClients, so the "Built-in / no setup needed" Google row disappears; Google now needs a BYO appoauth.clients.listtool stops advertising the slug tooExisting connections are untouched
Start, completion, refresh and reconnect all resolve the app by slug through
loadClient/the host config map, never through the list. The config entry deliberately stays declared: dropping it, or unsetting the env vars, is what would strand existing connections on a client the host can no longer resolve. Reconnect replays the connection's storedoauthClientverbatim, so it keeps working from the UI as well.Testing
New e2e-shaped scenario in
oauth-first-party.test.ts: an unlisted app is absent fromlistClients, yet still starts, completes, executes, and refreshes after a forced token expiry. Fullpackages/core/sdksuite (699) and the React picker suite green.