Normalize frontend error reports and wire the desktop reporter - #1785
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 77131a1 | Commit Preview URL Branch Preview URL |
Aug 27 2026, 10:29 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 77131a1 | Aug 27 2026, 10:31 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
fix/frontend-error-reporting
branch
from
August 27, 2026 20:41
e06141e to
0edd4dd
Compare
RhysSullivan
marked this pull request as ready for review
August 28, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A handled failure in the console — a request that 500s, a response that won't decode — was filed as a crash report with no message. The report was titled after the function that did the reporting, so every unrelated frontend failure merged into that one nameless bucket. On the wire the report read
Object captured as exception with keys: reasons, ~effect/Cause.Cause: every producer hands the reporter an Effect
Cause, a plain object with noname,messageorstack— nothing a crash reporter can title or group on.The desktop renderer had the same failure plus one of its own: it passed no reporter at all, so handled UI errors fell through
globalThis.reportErrorand were filed as unhandled crashes with the surface/action context dropped.Fix
toReportableError(packages/reactapi/error-reporting) turns whatever a call site has into a realError: aCause's failures and defects keep their message and stack, tagged errors are named by their_tag, and the original hangs offerror.cause. Applied at every dispatch path, and idempotent, so layering it is safe.executor.uitag block moved into a shared frontend error-reporter factory, so cloud and the desktop renderer differ only in transport.onHandledErrorto a renderer reporter, so handled UI errors are filed as handled and keep their context once the desktop bridge supplies a DSN. Builds without one keep the global-error-event fallback.Testing
e2e/cloud/frontend-error-reporting.test.ts: reload the integrations console with its API returning 500, intercept the report the page POSTs to its own origin, and assert the reported failure names the request and the status. Pre-fix it reportsObject captured as exception with keys: reasons, ~effect/Cause; with the fix,StatusCode error (500 GET .../api/integrations). It also asserts no report is marked synthetic, which is the grouping half of the bug and the half a readable message can hide: reporting the message as a bare string reads correctly but still groups on the reporting frame.packages/app/src/crash-reporting.test.ts): no desktop target boots for this change. The remaining unit tests inpackages/react/src/api/error-reporting.test.tscover only the input shapes a browser run cannot produce on demand — a thrown string, a tagged error declared without amessagefield, idempotency.Error-report fingerprinting is deliberately left to a separate PR.