feat: persist MCP install preferences - #1772
Merged
RhysSullivan merged 2 commits intoAug 28, 2026
Merged
Conversation
localStorage is per-origin, not per-account, so one key carried an org's transport and elicitation choices into every other org and every other user signed in through the same browser. The rendered install command differs per org, so the shared preference was wrong rather than merely surprising. Key the preferences by the active org slug, with one shared bucket for hosts that are not org-scoped (local, desktop). Nothing is migrated: the old global key is simply left unread, so those users fall back to defaults once. Switching orgs reloads that org's preferences during render rather than in an effect, so the save effect cannot write the previous org's choices under the new org's key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, when user clicks
advanceddropdown under the command for connecting agents, the options do not persist after page refresh (web) or desktop app restart:before.mp4
this PR adds local storage to persist the options
after.mp4
note
i understand the options in
advancedis only for building the visible command, this PR is changing for a better user experience when adding agents. tho i also wonder, if these options should become a server/daemon level config, as when im experimenting with the newly added?search_tools=true, it was awkward to update all of the mcp configs i have for different agents