Revalidate stale connection health verdicts automatically - #1708
Merged
Conversation
…uccessful invocations
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 432e488 | Commit Preview URL Branch Preview URL |
Aug 28 2026, 08:38 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 432e488 | Aug 28 2026, 08:40 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
…sing-credential guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents read a connection's persisted health verdict through connections.list, but nothing server-side ever re-checked it — only the web UI's mount probe and the manual Check now button. One transient probe failure left a sticky unhealthy verdict, and agents kept telling users to reconnect a connection that worked fine (invocation auto-refreshes OAuth tokens). Reported in shared-owner.
Two repair paths:
Deliberately untouched: tool-sync failure verdicts (only a successful sync clears them) and grants recorded invalid_grant-dead (reconnect genuinely required). PluginCtx.connections gains checkHealth to support the read path.
Tested: new unit coverage for both paths in connections.test.ts; e2e selfhost/mcp-oauth-reconnect-health and scenarios/health-checks-ui pass.