Repository navigation
Document SDK design agreements - #140
Merged
Merged
Conversation
We reached these agreements while working on the async Python SDK and decided they were worth documenting for posterity
daveleek
reviewed
Oct 7, 2026
daveleek
approved these changes
Oct 7, 2026
daveleek
left a comment
daveleek
left a comment
Contributor
There was a problem hiding this comment.
Seems like you ended up with a sentence that is a mix of two ideas, or you just lacked an ending for it. I've proposed one, but I'm giving a non-blocking approval here
sighphyre
reviewed
Oct 7, 2026
sighphyre
left a comment
sighphyre
left a comment
Member
There was a problem hiding this comment.
Chad.
Let's iterate a little before we merge though
Co-authored-by: David Leek <david@getunleash.io>
Co-authored-by: Simon Hornby <simon@getunleash.io>
sighphyre
reviewed
Oct 7, 2026
We've agreed that READY being first won't be a thing. It just needs removing from the title, too.
sighphyre
reviewed
Oct 7, 2026
Co-authored-by: Simon Hornby <simon@getunleash.io>
Co-authored-by: Simon Hornby <simon@getunleash.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reached these agreements while working on the async Python SDK
and decided they were worth documenting for posterity