Repository navigation
docs(readme): reconcile the README with LESdylan's Osionos page - #187
Merged
Merged
Conversation
LESdylan's README (his osionos page) is the team's version; where the two disagree his wins. The project is Osionos; prismatica stays only as the name of the public landing. His summary tiles are kept as written, including "52 points", which disagrees with the 16 points his own Modules section gives; the PR flags it rather than picking one. Added from ours, which his page lacks: the naming note on the track-binocle infrastructure identifiers.
…is page lacks His commands check out the latest tag on main, which is what scripts/verify/fresh-bringup.sh builds, and his prerequisites give a disk size. Added from ours, which his page lacks: the runbook and make help pointers, the local CA trust steps, the checks table, the demo account, the optional integrations and the development bring-up.
… block editor His table gives one owner per role; our per-member role column disagreed with it (two tech leads and a QA lead) and is dropped. Added from ours: a logins and areas table, the former members and the rstancu acknowledgement. Vadim's area drops Docker infrastructure and claims the editable block logic in osionos src/features/block-editor.
Dropped from ours where it contradicts his: no milestones exist (his page says milestones track the work), the sprint and stand-up rhythm, and the claim that ZAP runs on every pull request (it is workflow_dispatch only, as CodeRabbit noted on #186). Added from ours: the issue counts, the review rulesets and the commit-subject check.
His table, reasons, diagram and table groups replace ours. Added from ours: how make all applies the model migrations and which runner skips the integer-id files, and that access rules are evaluated by has_permission and the Rust ABAC evaluator.
His features list is an osionos database embed that GitHub cannot render, so our per-feature table with commit counts fills it. The Public API row no longer says the OpenAPI docs are served: his page lists serving them as missing work.
…ence His list replaces our 19 graded rows. Our core files, tests with their CI job, and docs are kept for the 8 of his modules our table covered; W12 and W13 have none from us. Dropped: Public API, advanced permissions, organisation, health and backups, GDPR, 2FA, both modules of choice, RAG, moderation and voice. His tracker-tab instructions are left out because the tracker does not exist on GitHub.
…tributions note His contributions are a database embed GitHub cannot render; his note and challenges are kept, and ours supply the per-member lines and the who-committed-where table that wiki pages link to. Vadim's line drops Docker infrastructure and claims the editable block logic: 42 of the 254 non-merge commits on osionos src/features/block-editor at main's pin 735c40fd, counted with git log --no-merges on that path.
… Osionos licence The License section said there was no root LICENSE; LESdylan added the Osionos Project License in 0978f11, and the section now follows its wording. Added from ours: the AI tools the repositories record, the 2026-11-04 trailer rewrite, the GoTrue reference, the loopback-only whiteboard, the narrow-by-design note, the security weaknesses link and the further documentation list. His empty to-fill section is left out.
The emoji headings from his page change GitHub's anchors (#-description, not #description).
The README now uses LESdylan's emoji headings, so #modules and #features-list no longer resolve on GitHub.
markdownlint flagged the lone italic stack lines (MD036, three) and the bare git@github.com (MD034); both were new against develop.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
394280d removed it when #184 dropped the figures from the README for lack of a source. The README now states 30 GB of disk and 23 GB for images and cache again (LESdylan's page), and CodeRabbit flagged the gap on #186. The figures come from c3a80d1: docker system df on the dev VM with the stack running, 2026-10-01. That commit already noted they were not taken from a clean build, so the row carries that caveat.
…thod "the commit groot `main` pins" read as incomplete (CodeRabbit on #186, contributions-method.md:9). It now reads "the commit that groot's `main` pins".
…does The summary tile said 52 points; the Modules section and the re-add of its table give 10 modules, 6 Majors and 4 Minors, 16 points. LESdylan confirmed 16 on 2026-11-05.
No project repository has a milestone: gh api repos/Univers42/<repo>/milestones?state=all returns 0 for groot, osionos, grobase, prismatica, hydrawn, osionos-mail and osionos-calendar (2026-11-05). LESdylan approved the change.
The note said "about 88%". Measured with the method in wiki/project/contributions-method.md at groot main 948487e's pins (root, osionos, grobase, opposite-osiris, hydrawn, mail, calendar, QA, monkey-bot; non-merge, .mailmap applied, bots and AI-agent identities left out): dlesieur 5,895 of 6,876 member commits, 85.7%, stated as 86%. The who-committed-where table, counted at 0bef3cb, gives the same 86% (5,878 of 6,837).
The licence claimed every file in the repository, including the git submodules, which carry their own terms: apps/grobase is AGPL-3.0 (apps/grobase/LICENSE) and vendor/monkey-bot is MIT (CodeRabbit on #186, LICENSE:11). LESdylan approved scoping it on 2026-11-05. The scope names .gitmodules rather than apps/* and vendor/*, because groot owns files under apps/ too (apps/README.md, apps/osionos-desktop/). The rest of his wording is unchanged.
Contributor
Author
|
@LESdylan Your 4 answers are applied — ready for your approval. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



One README for the project: LESdylan's Osionos page becomes the README, and where his page and ours disagree, his wins.
Why
The repository README (merged in #182 / #184) named the project Prismatica and graded 19 modules for 30 points. LESdylan's osionos page names it Osionos and claims 10 modules for 16 points. Two READMEs that disagree cannot both be defended. His page uses osionos-only syntax (
:::columns,[b],> [!info],osidbembeds) that GitHub shows as raw text, so it is rewritten here in plain GitHub markdown.What changed
apps/opposite-osiris).LICENSEhe added in 0978f11. It no longer says there is no root licence.src/features/block-editoris claimed instead (evidence below).#modules,#features-list).Added from ours: only what his page lacks and does not contradict
b8e1545d)track-binocleinfrastructure identifiersmake helppointers, local CA trust steps, checks table, demo account, optional integrations, development bring-uprstancuacknowledgementmake allapplies the model migrations;has_permissionand the Rust ABAC evaluatorosidbembed GitHub cannot render)Co-authored-bytrailer rewriteLeft out of his page
Dropped from ours because his page contradicts it
workflow_dispatch, as CodeRabbit noted on chore: promote develop to main (README rewrite) #186).Contradictions to settle (not resolved here)
/docs/. His page lists PUT/DELETE on personal tokens and serving the docs as missing work. The feature row no longer claims the docs are served.git show 394280db^:wiki/runbooks/fresh-machine.md, line 13). His figures are kept, and CodeRabbit asked on chore: promote develop to main (README rewrite) #186 for that row to be restored.Evidence
735c40fd: 42 of 254 non-merge commits onsrc/features/block-editor(vjan-nie 30 + 3, Vado 9). Command:git -C apps/osionos/app log --no-merges --format='%an <%ae>' 735c40fd -- src/features/block-editor | sort | uniq -c. Files touched most:ui/BlockEditor.tsx(18),model/usePlaygroundBlockEditor.ts(15),ui/PlaygroundPageEditor.tsx(9),ui/BlockContextMenu.tsx(6). Caveat: 3 of the 42 are second-brain gate commits that only touch the folder.markdownlint-cli2@0.18, default config,node:22-alpine), counts on develop → this branch: MD013 151 → 52, MD032 2 → 0, MD041 1 → 1. No rule fires that did not fire on develop.github-sluggeranchors). Caveat: github-slugger models GitHub's anchor rules but is not GitHub's renderer. The⚠️heading's anchor keeps U+FE0F.LESdylan's answers 2026-11-05: applied (1–4)
f76bda8d).gh api repos/Univers42/<repo>/milestones?state=all) (7c59ee7d).main948487ee's pins, counted withwiki/project/contributions-method.md(cd7fe809). The who-committed-where table, counted at0bef3cb3, gives the same 86%.LICENSEand the README's License section now apply the licence to this repository's own files. Each git submodule in.gitmoduleskeeps its own licence: grobase AGPL-3.0, monkey-bot MIT (0df762ba). The scope names.gitmodulesinstead ofapps/*,vendor/*because groot owns files underapps/too (apps/README.md,apps/osionos-desktop/), and.claudeis a submodule as well.Checks re-run in Docker: no markdownlint rule fires that does not fire on develop (MD013 151 → 52, MD032 2 → 0, MD041 1 → 1). 53 relative links, 0 broken. Points re-add: 10 modules, 16 points, 6 Majors, 4 Minors.