Skip to content

Fix/code scanning alerts - #180

Merged
SMOSTAFAH1 merged 4 commits into
developfrom
fix/code-scanning-alerts
Nov 4, 2026
Merged

SMOSTAFAH1 merged 4 commits into
developfrom
fix/code-scanning-alerts

Conversation

@SMOSTAFAH1

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 491340e8-01f7-4da1-b246-4f73cca9bca2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

- electron rest proxy: normalise the upstream path, drop __proto__ headers
- desktop app protocol: BaaS relay refuses targets off the configured origin
- curl downloads (scripts, Dockerfiles): HTTPS-only (--proto '=https' --tlsv1.2)
- ide-sandbox: npm install -g --ignore-scripts
- vault42-recover-dumps: sha256sum instead of md5sum for tree comparison
- smoke tests: message origin check; os.tmpdir() instead of /tmp
- justified NOSONAR on genuine false positives (seeded demo RNG, egress deny-lists,
  local-network http, demo seed credentials, maintainer CLIs)
- every third-party action pinned to its commit SHA (tag kept as comment)
- npm ci --ignore-scripts where lifecycle scripts are not needed
- HTTPS-only curl downloads; govulncheck pinned instead of @latest
@SMOSTAFAH1
SMOSTAFAH1 force-pushed the fix/code-scanning-alerts branch from 81e9eb7 to cbea2b6 Compare November 4, 2026 19:40
… CHECKs

p5_erase_canary failed on both fresh and legacy: generic p5_insert could not satisfy
ai_context_items_kind_check (IN without ::text casts) or osionos_page_comments_decided_check.
Widen p5_literal to match plain IN ('a','b') and force valid kind/scope/slug/body values
plus NULL decided_* columns.
… emoji

decided_check requires (status=open) iff both decided_* are null. When the canary
seeds decided_by as the user column, force status=accepted and decided_at=now().
Reactions emoji CHECK is char_length 1..16; force a short literal.
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@SMOSTAFAH1
SMOSTAFAH1 merged commit 1346c2a into develop Nov 4, 2026
39 checks passed
@SMOSTAFAH1
SMOSTAFAH1 deleted the fix/code-scanning-alerts branch November 4, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants