Repository navigation
Fix/ci - #165
Merged
Merged
Fix/ci#165
Conversation
The sync check and the ports-file read used [. [ splits and globs, so a host port or a path that picked up whitespace would be parsed as extra arguments instead of one comparison. This script is bash; [[ does not split.
…e test Resolve walks compose defaults, the ports file and the listener table with [. A name or a port value that split would skip the wrong row or treat a taken port as free. [[ keeps each comparison one word. The script is bash.
The direct-versus-keepalive choice used [ "$1" = direct ]. [ globs, so a mode value that was a pattern could match the wrong arm. [[ compares the string. The script is bash.
The app-container checks read memory, networks and env names through [. A value with whitespace would break the comparison into extra words and could pass a container that should fail. [[ does not split. The script is bash.
Exposure, header and bundle checks compare origins, DNS names and hit counts with [. An origin that split would change which branch ran. [[ keeps the comparison one string. The script is bash.
The IDE-mode and bundle-link checks used [ on container ids and link counts. A multi-word id would not be the test it looks like. [[ does not split. The script is bash.
The shared verify predicates in this file, including the integer-range helper, used [. Those values come from env and from HTTP answers; [ would split them. [[ does not. The script is bash.
The socket publisher tests paths and pin state with [. A path with whitespace would split and the test would not be the one written. [[ does not split. The script is bash.
build-images.sh decided its branches with [. A tag or a path that split would take the wrong branch. [[ compares one string. The script is bash.
deploy.sh gated its steps with [. An env value with whitespace would be more than one argument to [ and the gate would not mean what it says. [[ does not split. The script is bash.
env-init.sh tested keys and files with [. [ globs and splits, so a value containing a space or a glob character would not be compared as one string. [[ does not. The script is bash.
rollback.sh used [ for its guards. A split argument would change which guard fired. [[ keeps each test one comparison. The script is bash.
The funnel script tested node names and ports with [. Those strings come from config; [ would split them. [[ does not. The script is bash.
The node script tested addresses and state with [. A value with whitespace would be extra arguments rather than one comparison. [[ does not split. The script is bash.
reencrypt-mounts.sh used [ on its guards. A path that split would not be the path the guard names. [[ does not split. The script is bash.
The account round-trip verifier used [. A header or a body field with whitespace would split the assertion. [[ keeps it one comparison. The script is bash.
The guard-wire verifier used [. [ splits, so a wire value with whitespace would not be the comparison written. [[ does not. The script is bash.
The image-closure verifier used [ on its results. A split result would pass or fail for a different reason than the one written. [[ compares one string. The script is bash.
The image-closure fixture runner used [. A fixture path that split would not be the file the test names. [[ does not split. The script is bash.
Pin .claude at 1361f7d5 (was b6b87312). That commit adds the pull-requests rule: a PR is understood in five seconds. One commit, on top of the previous pin.
Pin apps/calendar at 64d9cfbc (was ddba418a). Those two commits deploy develop and main to Cloudflare Pages and check the build meta.
Pin apps/grobase at d1a63279 (was edc79b8f), 46 commits on top of the previous pin. The range lets Kong take bodies the WAF lifts, limits whiteboard bodies to their mongo-api paths, and builds pgvector without -march=native.
Pin apps/mail at e6455fac (was d19ca268). Those two commits deploy develop and main to Cloudflare Pages and check the build meta.
Pin apps/opposite-osiris at 4947f934 (was ea8836db), 78 commits on top of the previous pin. The range links a provider sign-in to an existing account (flag, default off), signs out other sessions before a password rotation, and fixes the newsletter footer and consent bar.
Pin vendor/born2root at 84fce5e7 (was 5c8f810f), 17 commits on top of the previous pin. The tip makes osionos_models seed the marketplace; the range also runs that models runner in the guest and reaches the tailnet through this host's tailscaled.
Pin vendor/monkey-bot at 0c1fa779 (was 4100e874), 102 commits on top of the previous pin. The range runs security-bot suites against a target, calibrates form-xss on mutant-lab, and documents the suite.
Pin vendor/scripts at 94b9def9 (was c619e5d1), 34 commits on top of the previous pin. The range rejects symlinked ancestors and unlinks symlinked cache entries before a render writes through them. The tip annotates Sonar S7027 false positives.
Pin apps/drawnosaurus at 3f1e9c43 (was ab6ccb98), 136 commits on top of the previous pin. The tip styles the /new route; the range adds an osionos-framed board and the phone and tablet menu. The checkout still has an uncommitted engine gitlink (812a03c -> 23c205d). This pin records 3f1e9c43 only.
Pin apps/osionos/app at d2cae96c, Merge branch feat/invite-inbox-bridge into main. The previous pin d538fab9 is not in this clone, so that range was not reviewed here. Nested gitlinks in this checkout are still uncommitted (http-gate, markdown-engine, osionos-ui, outbox-ledger, notion-database-sys, vendor/scripts). This pin records d2cae96c only.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The host can append Co-authored-by after the message passed to git commit. The rule makes the agent read the stored message and strip that trailer before the commit is pushed.
fd94f3b7 is not a fast-forward from ea8836db. The earlier pin claimed 78 commits on top of ea8836db and actually left the redesign lineage: SavedView, one page per doc, Forgot password, and the confirm/reset pages. ea8836db is the merge that still carries that history, and GitHub still serves the object.
9a769693 lived only on fix/follow-redirects-1.16.2. That branch diverges from main by more than a thousand commits, so merging it would not be a fast-forward. Main already locks follow-redirects 1.16.2 and passes npm audit --audit-level=high. Pin origin/main at 6f533a18 so the gitlink stays reachable when the fix branch is deleted. The override floor is Univers42/grobase#93, waiting on an approving review.
dec95f7 already documented and re-included bridge-page-access, bridge-share-rules, and bridge-access-generation. The fix/ci copies of those three lines duplicated what main has.
account-roundtrip still had 21 single-bracket tests, including the twin check in step_edge. The same unfinished mix was in gen-local-env, grobase-link-target, and reencrypt-mounts. expect ... [ ...] in public-verify stays [, because expect runs the test as "$@".
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Member
Author
|
Is this enough @LESdylan ? I merged the changes from main into fix/ci |
Subject requires single-command entrypoints. Wrap go/rust/static gates as make baas-ci-* so CI and local use the same recipe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI fixes on
fix/ci, plus submodule pin moves. This is not a no-op for product surfaces: the pins ship the ranges below (counts are commits on the new tip that are not on the previous pin).apps/osionos/appapps/grobase6f533a18: restore/verify gates,make alldeploy path, WAF request-line save, follow-redirects already at 1.16.2 on main.apps/drawnosaurus/newboard route, osionos embed build.vendor/monkey-botvendor/born2rootmake useremembers the profile, README docs link.vendor/scriptsapps/calendarapps/mail.claudeapps/opposite-osirisstays onea8836db(site overhaul with V4 saved view, one page per doc, Forgot password, confirm/reset).apps/graph_renderstays on48c865cf, the commit the studio pack was built from.Other changes on this branch: bash
[→[[in the public/verify and related scripts; AI image COPY/dockerignore for the share-rule bridge modules; footprint bats fake-dockerexecfailure so vault-restore tests match the MinIO TLS gate; Cursor rule that forbids a co-author trailer on commits.Test plan
make allsafety + footprint) green on the tipclone --recursive + make allvia workflow_dispatch onfix/ci(skipped on PRs)