Skip to content

fix(deps): hold follow-redirects and systeminformation above the high advisories - #93

Open
danielfdez17 wants to merge 7 commits into
mainfrom
fix/follow-redirects-floor-on-main
Open

danielfdez17 wants to merge 7 commits into
mainfrom
fix/follow-redirects-floor-on-main

Conversation

@danielfdez17

@danielfdez17 danielfdez17 commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add npm overrides so follow-redirects stays at ^1.16.2 and systeminformation at ^5.33.16.
  • Main already locks those versions; the overrides stop a later refresh from dropping back through the high advisories.

Test plan

  • npm audit --omit=dev --audit-level=high --no-fund exits 0 on this tip

Made with Cursor

Summary by CodeRabbit

  • Chores
    • Updated internal package configuration. This update does not change the app’s visible features or behavior. No other user-facing changes are included in this release.

… advisories

Main already resolves follow-redirects 1.16.2 and systeminformation 5.33.19. The overrides keep a later lockfile refresh from dropping them through GHSA-mrwp-f3q8-3g9p and the systeminformation highs at 5.33.15.
Copilot AI balanced review requested due to automatic review settings November 4, 2026 16:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e7e5dace-7744-441e-bd13-c0a63511d70b

No actionable comments were generated in the recent review.

Walkthrough

The package overrides add version constraints for follow-redirects and systeminformation. The existing @grpc/grpc-js override remains unchanged.

Changes: Dependency overrides

Layer / File(s) Summary
Add dependency version constraints
src/package.json
The overrides set follow-redirects to ^1.16.2 and systeminformation to ^5.33.16. The existing @grpc/grpc-js override remains unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • Univers42/grobase#53: Updates the resolved follow-redirects version to 1.16.1; this PR adds an override targeting ^1.16.2.

Suggested reviewers: lesdylan

Merge Risk: Minimal · previous review 0236c

The dependency overrides are consistent with the locked dependency tree and should preserve the intended minimum versions during installation.

Architecture risk: Low · up to 0236c

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/package.json: The overrides add follow-redirects at ^1.16.2 and systeminformation at ^5.33.16; the existing @grpc/grpc-js override is retained.
Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two packages this PR pins through npm overrides, follow-redirects and systeminformation, and states the purpose of keeping them above the high-severity advisories. The raw summary …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two packages this PR pins through npm overrides, follow-redirects and systeminformation, and states the purpose of keeping them above the high-severity advisories. The raw summary confirms the change adds these two overrides to src/package.json and leaves the existing @grpc/grpc-js override unchanged. The title is specific and matches the main change, so it passes.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e17b9c39-6f8b-4924-8118-6da06f98ff9a
Commits

Reviewing files that changed from the base of the PR and between 6f533a1 and 0236c5f.

Files selected for processing: 1

  • src/package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

danielfdez17 added a commit to Univers42/groot that referenced this pull request Nov 4, 2026
9a769693 lived only on fix/follow-redirects-1.16.2. That branch diverges from main by more than a thousand commits, so merging it would not be a fast-forward. Main already locks follow-redirects 1.16.2 and passes npm audit --audit-level=high. Pin origin/main at 6f533a18 so the gitlink stays reachable when the fix branch is deleted. The override floor is Univers42/grobase#93, waiting on an approving review.
@LESdylan

LESdylan commented Nov 6, 2026

Copy link
Copy Markdown
Member

@danielfdez17 if you can repair it. It would be very much appreciated 👯

…ing 56

A curl recv failure under set -e aborted the HS256 parity step before the assertion, so the standalone gate died with curl's own status and no FAIL line.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI balanced review requested due to automatic review settings November 9, 2026 10:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

The gate's loopback bootstrap and JWKS addresses stay clear-text on this run's private network; the same NOSONAR marker the other verify scripts use keeps that explicit.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI balanced review requested due to automatic review settings November 9, 2026 10:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

danielfdez17 and others added 2 commits November 9, 2026 12:47
RUSTSEC-2026-0459 is the bundled SQLite before 3.54.0. Published
deadpool-sqlite still pins rusqlite 0.40, so the reader pool opens
rusqlite 0.41 directly. pin-utils stays ignored: it is only on the
optional DynamoDB graph and has no fixed release.

Co-authored-by: Cursor <cursoragent@cursor.com>
govulncheck now reaches the two-block frame panic through the Mongo
driver. 1.20.2 is the fixed release.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI balanced review requested due to automatic review settings November 9, 2026 11:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI balanced review requested due to automatic review settings November 9, 2026 11:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

The merge of main left serde_derive 1.0.229 depending on syn 2.0.117.
cargo deny --locked refuses to rewrite that line, so the advisory scan
never starts.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI balanced review requested due to automatic review settings November 9, 2026 12:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@danielfdez17

Copy link
Copy Markdown
Member Author

Everything should now be repaired @LESdylan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants