fix: testproject wait

[NoelStephensUnity]

Purpose of this PR

This PR fixes three waits that could never fail (so a spawn or disconnect that never happened was still reported as a pass).

• MessageOrderingTests.RpcOnNetworkSpawn:
  • It tried to find the spawned object within SpawnedObjects using its GlobalObjectIdHash instead of its NetworkObjectId, so the lookup never matched.
  • The wait loop around it set its success flag after a single pass, because the continue sat inside the foreach (it only skipped to the next client, not the next wait).
  • It now waits on the NetworkObjectId through WaitForConditionOrTimeOut.
• MessageOrderingTests.SpawnChangeOwnership and MultiClientConnectionApproval.ConnectionApprovalMismatchTest created a TimeoutHelper that was never passed to WaitForConditionOrTimeOut, and the tests' both checked this using an Assert.False(timeoutHelper.TimedOut) (i.e. if it is never used...it could never possibly fail..).

PR Scope:

Test-only changes to MessageOrdering.cs and MultiClientConnectionApproval.cs. No runtime code changes.

Jira ticket

N/A

Documentation

• No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Fixture	Passed	Failed
MessageOrderingTests	3	0
MultiClientConnectionApproval	11	0

Functional Testing

Manual testing :

• Manual testing done

Automated tests:

• Covered by existing automated tests
• Covered by new automated tests

Does the change require QA team to:

• Review automated tests?
• Execute manual tests?
• Provide feedback about the PR?

Up-port

Not needed. This PR targets develop-3.x.x.

Backports

develop-2.0.0 has the same three bugs. A port to develop-2.0.0 will follow.

[u-pr]

⚠️ Some settings were ignored in '.pr_agent.toml (repository root)' repo settings

Check the configuration's TOML syntax, permitted settings, and size limit. See the error below.

---

Error message:
Ignored prohibited settings: github_app.handle_pr_actions. Permitted settings were applied.

Configuration content:

# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/

[github_app]
handle_pr_actions = ['opened', 'ready_for_review']  # PR events that auto-run pr_commands
pr_commands       = ["/harness-review"]             # what runs on those events
reviewer_commands = ["/harness-review"]             # what runs when @u-pr is added as reviewer

[u-pr]

💡 Harness Review

The change connects the timeout checks and corrects the client spawn lookup, but the repaired spawn wait uses a shorter deadline than the test specifies.

_{Reviewed commit 1ee5109}

_{🤖 Helpful? 👍/👎}

[NoelStephensUnity]

@u-pr please review again

[u-pr]

The changes look good.

Summary of Review

• Timeout Helper Configuration (MessageOrdering.cs & MultiClientConnectionApproval.cs):
  • The previous finding regarding the wait budget in RpcOnNetworkSpawn has been addressed by explicitly setting new TimeoutHelper(4.0f).
  • In SpawnChangeOwnership and ConnectionApprovalMismatchTest, setting new TimeoutHelper(8.0f) and passing the helper into WaitForConditionOrTimeOut preserves the 8-second default wait budget while ensuring timeoutHelper.TimedOut is actually updated and evaluated.
• Lookup Key Correction (MessageOrdering.cs):
  • Updating m_SpawnedNetworkObjectId to use serverNetworkObject.NetworkObjectId rather than GlobalObjectIdHash corrects the key used to inspect SpawnManager.SpawnedObjects.
• Wait Condition Refactor (MessageOrdering.cs):
  • Extracting the client check into AllClientsSpawnedObject cleanly replaces the previous loop logic and integrates properly with NetcodeIntegrationTest.WaitForConditionOrTimeOut.

_{🤖 Helpful? 👍/👎}

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@              Coverage Diff               @@
##           develop-3.x.x    #4174   +/-   ##
==============================================
  Coverage          78.19%   78.19%           
==============================================
  Files                153      153           
  Lines              26272    26272           
==============================================
  Hits               20544    20544           
  Misses              5728     5728           

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu	76.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
com.unity.netcode.gameobjects	78.19% <ø> (ø)

ℹ️ Need help interpreting these results?

[NoelStephensUnity]

@u-pr please review again

[u-pr]

The latest changes converting MessageOrderingTests to derive from NetcodeIntegrationTest look excellent.

Review Summary

• NetcodeIntegrationTest Lifecycle & Fixtures (MessageOrdering.cs):

  • Parameterizing with [TestFixture(HostOrServer.Host)] and [TestFixture(HostOrServer.Server)] ensures coverage across both host and dedicated server configurations.
  • Setting NumberOfClients => 1 preserves the topology required by these ordering tests.
  • Creating prefabs in OnServerAndClientsCreated and invoking ResetStatics() in both OnSetup and OnTearDown keeps test execution isolated and prevents static state leakage.

• Wait Helpers & Timeout Budgets (MessageOrdering.cs):

  • SpawnChangeOwnership cleanly replaces the manual counting of NetworkObjectTestComponent instances with WaitForSpawnedOnAllOrTimeOut, keeps the 8.0s timeout allowance, and verifies ownership assignment on the non-authority client.
  • SpawnRpcDespawn dynamically evaluates the client count using TotalClients, which accommodates both host and server modes, and uses Func<StringBuilder, bool> in WaitForConditionOrTimeOut for actionable error messages if a condition fails.
  • RpcOnNetworkSpawn preserves its wait budgets (4.0s for spawning, 5.0s for RPC execution, and 2.0s for handler destruction) while integrating AssertOnTimeout and verifying handler lifecycles on all participating managers.

• Multi-Client Connection Approval (MultiClientConnectionApproval.cs):

  • The 8.0s TimeoutHelper continues to be properly passed to NetcodeIntegrationTest.WaitForConditionOrTimeOut, ensuring timeouts are registered and evaluated.

_{🤖 Helpful? 👍/👎}