Fix Open Terminal - #225
Merged
Merged
Fix Open Terminal #225
Conversation
- Split $TERMINAL into executable and arguments without invoking a shell, so values like 'wezterm start' work. - Pass the working directory as separate arguments via ProcessStartInfo.ArgumentList instead of embedding it in a quoted Arguments string, so paths containing quotes are preserved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
/review |
IGuscin
approved these changes
Sep 30, 2026
IGuscin
left a comment
There was a problem hiding this comment.
Tomas verified that open terminal works properly, both on Win and Linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
Windows: no terminal window opened on CoreCLR
How it broke
OpenTerminal started cmd.exe with new ProcessStartInfo("cmd.exe") { WorkingDirectory = ... } and left UseShellExecute at its default. The default is different on each runtime:
Fix
Set UseShellExecute = true explicitly. This brings back the old Mono behaviour on both runtimes.
Linux: OpenTerminal was not implemented
OpenTerminal had no RuntimePlatform.LinuxEditor case, so on Linux it fell through to default and threw Don't know how to open terminal on LinuxEditor.
Claude provided default implementation so this works now just fine
2026-09-25.16-49-46.mp4