Repository navigation
fix: remediate patchable dependency alerts (#77, #76, #67, #66, #64, #33) - #78
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
superdav42
marked this pull request as ready for review
October 14, 2026 21:19
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-lock.json, preserving lockfile v2 and the existing React 18 / WordPress component APIs.^5.111.1and override only@wordpress/components' UUID dependency to^11.1.1. UUID 11 retains both CommonJS and ESM exports; this avoids upgrading the WordPress component library solely to fix UUID.9.0.7). All other minimatch entries resolve to patched3.1.5; source-map-js resolves to1.2.2; adm-zip is absent.Issue disposition
Resolves #77
Resolves #76
Resolves #67
Resolves #66
Resolves #64
Resolves #33
For #57 and #65: not resolved. Registry checks confirm the latest braces (
3.0.3) and sprintf-js (1.1.3) releases are still vulnerable and have no patched release. The full npm audit reports 30 findings cascading from these two dependencies. Removing them requires replacing/upgrading their parent tooling, not just refreshing the lockfile. Do not close these issues on merge.Some linked issues are stale: before this change, the live GitHub alert inventory listed only UUID, three minimatch alerts, braces, and sprintf-js. The new lockfile verifies the desired patched/absent states for the other linked issues too. GitHub alerts must be rechecked after merge; this PR does not claim they have already closed.
Verification
git diff --check: passed.npm audit --omit=dev --json: zero vulnerabilities. This applies only to npm's dependency classification; it is not a claim that WordPress-externalized dependencies are risk-free at runtime.npm audit --json: 30 findings (15 moderate, 15 high), all rooted in the unpatched braces and sprintf-js advisories; no UUID, minimatch, webpack, source-map-js, or adm-zip findings.npm ci --ignore-scripts --loglevel=error: passed on Node 22.22.2 / npm 10.9.7.npm run build: passed (webpack 5.111.1; 21 Sass warnings plus a Babel plugin deprecation). Generated assets were restored after verification; this is a manifest/lockfile-only PR, not a release asset refresh../node_modules/.bin/grunt --no-color: passed.eslint --print-config src/js/frontend/index.js; no source lint pass is claimed.v4()/validate()smoke check: passed. The installed WordPress component consumers usev4()without options.Scope and follow-up
No source, UI, linter configuration, test infrastructure, PHP, or release-version changes are intended. Reference patterns: existing npm overrides in
package.json, webpack scripts inpackage.json, andGruntfile.js's packaging task. Rollback is reverting the manifest/lockfile commit and runningnpm ci --ignore-scripts.Remaining paths: braces is pulled in by micromatch (through TypeScript lint tooling and Grunt); sprintf-js is pulled in by WordPress i18n, Grunt's argparse and underscore.string, and prettier-eslint's argparse. Follow-up on #57 / #65 should inspect these parents in
package-lock.json, preserve the existing ESLint configuration and Grunt packaging behavior, and verify with a clean install, full audit, production build, and packaging. No unpatched package is being silently risk-accepted here.PR #30 also edits
package.jsonto add quality-check scripts; preserve both its script additions and this PR's dependency changes if it needs conflict resolution.aidevops.sh v3.39.27 plugin for OpenCode