fix: send payment_received receipt after manual payment confirmation and email verification #2055

Goal

Send the payment_received system email (customer receipt and admin notice) in two cases that currently send nothing:

1. A network admin confirms a pending manual payment.
2. A free signup becomes active after its customer verifies their email address.

Evidence

Release 2.18.0 smoke test on a fresh dev network at origin/main c8b5ffe (2026-10-28), with mail captured by Mailpit:

• Manual payment: Premium checkout with the Manual gateway left payment Welcome to WP Multisite WaaS Discussions! #1 and membership Welcome to WP Multisite WaaS Discussions! #1 pending, as expected. An admin then set the payment to Completed with "Activate membership?" on. The membership became active and the site was published, and "Your site is ready!" was sent. No payment_received email went to the customer or the admin. Event log rows for this step were changed payment and changed membership only.
• Free signup with email verification: the thank-you page says "a receipt for your purchase has been emailed to you". After the customer followed the verification link, the site went READY and "Your site is ready!" was sent. No "Your free membership is active" / payment_received email was sent.
• Both paths are unchanged since v2.17.2, so this is long-standing, not a regression.

How

• payment_received fires only from Payment_Manager::handle_payment_success() (inc/managers/class-payment-manager.php:109-219), which listens to wu_gateway_payment_processed.
• wu_gateway_payment_processed comes from Base_Gateway::trigger_payment_processed() (inc/gateways/class-base-gateway.php:901). The checkout calls it for free/trial orders only when email verification is not pending (inc/checkout/class-checkout.php:1074 and :1108). Gateways call it on gateway-confirmed payments.
• Manual confirmation path: Payment_Edit_Admin_Page::handle_save() (inc/admin-pages/class-payment-edit-admin-page.php:1458+) activates the membership but never triggers payment processed.
• Verification path: Customer_Manager::maybe_verify_email_address() / transition_customer_email_verification() (inc/managers/class-customer-manager.php:183, :245) publish the deferred free signup but never trigger payment processed.
• Trigger it once in each path, with the payment's gateway (wu_get_gateway($payment->get_gateway())) or the manual/free gateway. Guard against duplicate events, for example by checking whether a payment_received event already exists for the payment, so a repeated save or verification can't send twice.

Files Scope

• inc/admin-pages/class-payment-edit-admin-page.php
• inc/managers/class-customer-manager.php
• inc/managers/class-payment-manager.php
• tests/WP_Ultimo/Managers/Payment_Manager_Test.php
• tests/WP_Ultimo/Managers/Customer_Manager_Test.php

Verification

• vendor/bin/phpunit --filter 'Payment_Manager_Test|Customer_Manager_Test'
• vendor/bin/phpcs on the changed files.
• Dev site with Mailpit: (1) a manual Premium checkout, then admin Completed + "Activate membership?", sends exactly one customer receipt and one admin notice; (2) a free signup with verification sends "Your free membership is active" once, after verification; (3) re-saving the completed payment sends nothing further.

aidevops.sh v3.39.49 plugin for OpenCode

CI Repair Feedback (from PR #2064)

The previous worker's PR #2064 had terminal failed CI checks. A head-bound
finalizer is routing this issue for redispatch. The next worker should address these failures.

Terminal failed checks

• cypress (8.5, chrome): failure — check URL — primary failing-check evidence

Worker guidance

1. Recover the previous PR branch/commits and continue that work; do not restart from scratch.
2. Read every terminal check URL above and preserve the accumulated evidence.
3. Rebase the recovered work onto current origin/main, then fix the code rather than weakening CI.
4. Run every listed local check and create the replacement PR from the recovered branch.

Routed by deterministic merge pass (pulse-merge.sh).

In-place repair fallback

• Reason: the bounded PR-branch repair session exhausted its retry budget
• Retry: re-run the deterministic merge pass after restoring access to branch feature/auto-20261027-201432-gh2055; keep PR fix: send payment_received after manual confirmation and email verification (GH#2055) #2064 open until that retry is impossible.

In-place repair attempt outcomes

• Attempt 1: stage=head_fetch; result=launch_failed; failure_reason=pr_head_fetch_failed; next_action=verify_remote_branch_access_and_retry
• Attempt 2: stage=head_fetch; result=launch_failed; failure_reason=pr_head_fetch_failed; next_action=verify_remote_branch_access_and_retry

CI Repair Feedback (from PR #2091)

The previous worker's PR #2091 had terminal failed CI checks. A head-bound
finalizer is routing this issue for redispatch. The next worker should address these failures.

Terminal failed checks

• PHP 8.2: failure — check URL — primary failing-check evidence
• PHP 8.3: failure — check URL — primary failing-check evidence
• PHP 8.4: failure — check URL — primary failing-check evidence
• PHP 8.5: failure — check URL — primary failing-check evidence

Worker guidance

1. Recover the previous PR branch/commits and continue that work; do not restart from scratch.
2. Read every terminal check URL above and preserve the accumulated evidence.
3. Rebase the recovered work onto current origin/main, then fix the code rather than weakening CI.
4. Run every listed local check and create the replacement PR from the recovered branch.

Routed by deterministic merge pass (pulse-merge.sh).

In-place repair fallback

• Reason: the bounded PR-branch repair session exhausted its retry budget
• Retry: re-run the deterministic merge pass after restoring access to branch feature/auto-20261106-135043-gh2055; keep PR GH#2055: send deferred payment receipts #2091 open until that retry is impossible.

In-place repair attempt outcomes

• Attempt 1: stage=preparing; result=launch_interrupted; failure_reason=headless_launch_interrupted; next_action=retry_launch
• Attempt 2: stage=preparing; result=launch_interrupted; failure_reason=headless_launch_interrupted; next_action=retry_launch