Repository navigation
Conversation
(still need to actually test for numerical correctness.)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #538
Overview
Creates UxDataArray.laplacian(), as requested by #538. Currently only supports Laplacian of a scalar field. The Laplacian is the divergence of the gradient, laplacian(q) == div(grad(q)).
Very intentionally put
*before thescale_by_radiuskwarg here to ensure nobody starts writing arr.laplacian(True) or arr.laplacian(False); see also #1573. Importantly, this also leaves room for later adding a "Laplacian of a vector field" feature like arr.laplacian(other), without needing any deprecation cycle first.Draft PR; still need to do the following:
Small expansion of scope:
Expected Usage
PR Checklist
General
Testing & Benchmarking
Documentation and Examples
docs/api.rst; internal (private) function names start with an underscore (_)AI Disclosure
AI Usage: GitHub Copilot's inline code suggestions, some Claude