Remove lat_spec schema workaround after ToolRegistry releases union fix #165

Activity

1. rajeeja commented on Oct 23, 2026

   

   rajeeja

   on Oct 23, 2026

   CollaboratorAuthor

   More actions

   toolregistry 0.19.0 is out (2026-10-23) and does contain Oaklight/ToolRegistry#269. #193 takes it. Walking the checklist:

   • Upgrade the minimum toolregistry version — floor is now >=0.19.0, with toolregistry-server>=0.7.0 beside it.
   • Refresh uv.lock and package metadata.
   • Confirm run_analysis and plot_dataset serve lat_spec as number | array<number> — they do.
   • Confirm a JSON array such as [-60, 60] passes validation — the existing wire tests cover this and pass.
   • Remove _UNTYPED_UNION_SCHEMAS / _type_untyped_unions — not done, see below.
   • Retain the regression tests against real registry execution.
   • Re-measure the payload budgets.

   Why the workaround stays

   The fix works, but it is not sufficient for this parameter. lat_spec is annotated tuple | float | list[Any] | None, and tuple and list both render as array, so 0.19 emits:

   anyOf: [ {"type":"array","items":{}}, {"type":"number"}, {"type":"array","items":{}} ]
   

   The array branch twice, with untyped items. Valid JSON Schema, and a client would work from it, but it is a duplicated branch in a payload we budget and it drops the item type we know.

   So the helper changed role rather than going away: it used to fill an absent type, and now replaces a poor rendering with the canonical one. Net effect on the served spec is negative — 36271 → 36143 bytes — because the duplicate goes away.

   Two ways to actually close this:

   1. Narrow the annotation to float | list[float] | None and drop tuple. JSON has no tuple, so no MCP client could ever send one; the only caller who can is Python. That would likely make upstream's rendering correct and the helper genuinely dead.
   2. Ask upstream to de-duplicate identical anyOf branches.

   (1) is ours to do and is probably the right follow-up. Leaving this open and re-scoped to that.

   Separately, worth knowing: toolregistry-server 0.7.0 began inferring tool annotations, and marked manage_session and resume_workflow readOnlyHint=True — both change state. #193 makes our ratings authoritative and clears inferred hints on tools we left unrated.
2. rajeeja

   closed this as completedin #193on Oct 23, 2026