Fix CDA GUI data query workflow#1788
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Closed
# Conflicts: # cda-gui/src/pages/data-query/index.jsx
MikeNeilson
reviewed
Jun 18, 2026
MikeNeilson
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable so far. Somewhat large number of changes, but a lot of that appears to be cleanup and reorganization.
Collaborator
Author
|
Let me know if you have any concerns! Or if you're looking to do another review before approving or requesting changes @MikeNeilson This does also resolve some feedback we got on improving the query tool. i.e. |
# Conflicts: # cda-gui/package-lock.json # cda-gui/package.json # cda-gui/vite.config.js
MikeNeilson
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR got a bit large. I would be working through one issue and decide to fix another item i've been holding off on. See screenshots below for an exhaustive list of fixes / improvements.
Updates the CDA GUI data query workflow to make guided selection, time-series loading, and result rendering more reliable and usable.
Highlights:
Related Issue
Closes #1721
Validation
npm run lintnpm run format:checkgit diff --checkhttp://127.0.0.1:5173/cwms-data/data-queryScreenshots
Checklist