CDA-119: Content Length for getOne, getAll#1771
Open
zack-rma wants to merge 12 commits into
Open
Conversation
…o bugfix/ratings-content-length
…o bugfix/ratings-content-length
zack-rma
changed the title
rma-bryson
requested changes
Jun 23, 2026
| byte[] bytes = result.getBytes(); | ||
| ctx.header(Header.CONTENT_LENGTH, String.valueOf(bytes.length)); | ||
| ctx.res.getOutputStream().write(bytes); | ||
| } catch (IOException ex) { |
Collaborator
There was a problem hiding this comment.
Isn't the exception handling centralized in ApiServlet? Why are these catch blocks needed in the controllers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated getOne and getAll endpoints to properly report content length in response header.
Related Issue
Closes #1720
Validation
Included integration test for Ratings controller, as that was the original ask.
Checklist