492/antiquarian bibliographic work - #505
Merged
Merged
Conversation
tcouch
force-pushed
the
492/antiquarian-bibliographic-work
branch
from
July 22, 2026 19:11
d775aaf to
eb0f74f
Compare
tim-band
reviewed
Jul 24, 2026
| name='bibliographic', | ||
| field=models.BooleanField(default=False), | ||
| ), | ||
| migrations.RunPython(add_bibliographic_works, reverse_code=migrations.RunPython.noop), |
tim-band
approved these changes
Jul 24, 2026
|
|
||
| collate_unknown(w) | ||
|
|
||
| self.assertEqual(w.book_set.filter(unknown=True).count(), 1) |
Collaborator
There was a problem hiding this comment.
I'm really not super clear about what this is testing. Are we saying that additional_unknown has gone missing? We could test for that explicitly... anyway it feels like we need a comment explaining what these assertions are actually asserting.
| </i></button> | ||
|
|
||
| {% if can_edit and has_object_lock %} | ||
| {% with tlinks=object|testimonium_links_for_work:work %} |
496/add publishable flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #492