Skip to content

Add channel edge handling to PinholeSPECTUB - #1749

Open
TommasoFerri97 wants to merge 3 commits into
UCL:masterfrom
TommasoFerri97:ChannelEdge-PR
Open

Add channel edge handling to PinholeSPECTUB#1749
TommasoFerri97 wants to merge 3 commits into
UCL:masterfrom
TommasoFerri97:ChannelEdge-PR

Conversation

@TommasoFerri97

Copy link
Copy Markdown

I have not yet signed the STIR Contribution License Agreement. Please let me know the required procedure.

Changes in this pull request

This pull request adds support for channel-edge pinhole collimators in PinholeSPECTUB, while preserving the existing knife-edge implementation.

The main changes are:

  • Added a collimator type parameter to distinguish between knife-edge and channel-edge pinholes.
  • Added the channel width (dycm) to the pinhole geometry definition.
  • Extended the collimator parameter reader to load the additional channel-edge information.
  • Added the geometrical treatment of finite channel width in the PinholeSPECTUB weight calculation.
  • The original knife-edge calculation is retained when the collimator type is knife or when the channel width is set to zero.

Testing performed

The channel-edge implementation was tested with a PinholeSPECTUB reconstruction using a finite-width pinhole channel.

Checklist before requesting a review

  • I have performed a self-review of my code
  • The code builds and runs on my machine

Contribution Notes

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in STIR (the Work) under the terms and conditions of the Apache-2.0 License.
  • I (or my institution) have signed the STIR Contribution License Agreement (not required for small changes).

@codacy-production

codacy-production Bot commented Aug 31, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 36 complexity · 46 duplication

Metric Results
Complexity 36
Duplication 46

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant