fixed all warnings - #1748
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | -4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Collaborator
Author
|
Ready for your review @KrisThielemans |
KrisThielemans
requested changes
Sep 2, 2026
KrisThielemans
left a comment
KrisThielemans
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. Useful, but I do hope it doesn't create conflicts with our many other PRs...
* Potential bug, in PETSIRD if x and y axis are the same size then z won't be checked.
NikEfth
force-pushed
the
fix_warnings
branch
from
September 7, 2026 08:55
a5bd4b6 to
fb29724
Compare
KrisThielemans
approved these changes
Sep 8, 2026
Collaborator
|
Same CI failure as in #1754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just fixed all warnings I was getting.
I was also thinking to replace
rand()withrandom.hbut not sure about it.