Repository navigation
test(install): guard Unix mode checks on Windows - #1458
Merged
Merged
Conversation
Git Bash does not expose exact Unix permission bits. Keep the content and executable checks on every platform, and run Windows acceptance shards before merging. Refs #1406
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Related #1406
The successful offline install case passes its content and executable checks on Windows, then fails because Git Bash does not expose exact Unix permission bits. Windows acceptance shards now run on pull requests so this check is exercised before merge.
Changes
Checklist