Skip to content

fix(ci): keep docs and Windows installer checks reliable #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chemaclass wants to merge 2 commits into from
Closed

fix(ci): keep docs and Windows installer checks reliable #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f45915e
fix(ci): isolate docs checks by pull request
Chemaclass Oct 30, 2026
23469b0
test(ci): use an executable installer fixture
Chemaclass Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
workflow_dispatch:

concurrency:
group: pages
cancel-in-progress: false
group: docs-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

jobs:
build:
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/install_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ fi
case "$INSTALL_TEST_DOWNLOAD_RESULT" in
failure) printf 'partial download\n' >"$target"; exit 22 ;;
empty) : >"$target" ;;
*) printf 'new binary\n' >"$target" ;;
*) printf '#!/bin/sh\nexit 0\n' >"$target" ;;
esac
SH
chmod +x shims/curl
Expand All @@ -249,7 +249,7 @@ SH

if [ "$result" = success ]; then
assert_successful_code "" "" "$status"
assert_same 'new binary' "$(cat destination/bashunit)"
assert_same "$(printf '#!/bin/sh\nexit 0')" "$(cat destination/bashunit)"
assert_is_file_executable destination/bashunit
assert_not_empty "$(find destination/bashunit -perm 0744 -print)"
else
Expand Down
Loading