Repository navigation
fix(install): clearer address label and an honest updater dry-run - #58
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SZ4EYrCPbq3hhNsUVRT46K Signed-off-by: Claude <noreply@anthropic.com>
… is on Same fix the installer already had, for update.sh and update.ps1. The shell path is covered by test-installers.sh; the PowerShell path is validated by the Windows CI job. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SZ4EYrCPbq3hhNsUVRT46K Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two small fixes found while reading the installer scripts' output:
install.sh,update.sh,uninstall.shand the three PowerShell equivalents (and the tests/docs that quote it). It was a literal translation; Spanish is unchanged.update.shandupdate.ps1). It readsTRINAXAI_PWA_HOSTfrom.env, as the installer's dry-run already did.test-installers.shcovers LAN off and on for the shell path.How it was checked
bash test-installers.sh, including the two new update dry-run cases, passes locally.install.ps1,uninstall.ps1,update.ps1) could not be run where I work (nopwsh). The Windows jobs of CI runtest-installers.ps1, which is what validates them: please treat a greenPowerShell installers (windows-2025)as the check for that part.Type of change
Checklist
Generated by Claude Code