Conversation
- Change in `Prompt` to embed MIME content type - Addition of `Url` with a specific type to embed MIME content type and language - All served with an example
|
I would prefer that the Prompt itself is not changed in function. Hence if an organisation wants to do something with predefined markup that is fine, they can use Url |
|
Since |
thbar
left a comment
There was a problem hiding this comment.
I did a first round mostly on "details". I will mull over the general design & see if I can comment more on the overall structure (need more time).
| @@ -0,0 +1,131 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- (C) Copyright 2005-2012 CEN SIRI --> | |||
There was a problem hiding this comment.
| <!-- (C) Copyright 2005-2012 CEN SIRI --> | |
| <!-- (C) Copyright 2005-2026 CEN SIRI --> |
|
During the SIRI-SX meeting of 19 may 2026, the assessment was that the PR is not yet ready for review. Discussed changes / paints points are to be addressed. |
- Adding the element Url in ActionDataStructure - Adding the attribute contentType for both Prompt and Url elements - Defining the enumeration related to contentType
|
Based on feedback from the meeting of 19 May 2026, I made the following changes in the PR:
|
…ndurl.xml delete faulty example from previous try
TuThoThai
left a comment
There was a problem hiding this comment.
As per discussion with @haeckerbaer, @skinkie and @thbar on 16 July 2026
|
What is blocking this one? |
|
It PR was approved at the SIRI plenary of 29 September 2026, so we can merge it. |
thbar
left a comment
There was a problem hiding this comment.
2 suggestions to remove some content types.
For video (already in use in UK as mentioned by @tim-rivett, not sure which content type would be fine at this point).
Also: @TuThoThai I didn't find the place where we advertise that the content-type/language combination must be unique !
| <xsd:enumeration value="image/bmp"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Bitmap image file</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:enumeration> |
There was a problem hiding this comment.
| <xsd:enumeration value="image/bmp"> | |
| <xsd:annotation> | |
| <xsd:documentation>Bitmap image file</xsd:documentation> | |
| </xsd:annotation> | |
| </xsd:enumeration> |
I would have a hard-time seeing anyone broadcasting BMP files (big & uncompressed)
| <xsd:enumeration value="audio/x-wav"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Waveform audio file</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:enumeration> |
There was a problem hiding this comment.
| <xsd:enumeration value="audio/x-wav"> | |
| <xsd:annotation> | |
| <xsd:documentation>Waveform audio file</xsd:documentation> | |
| </xsd:annotation> | |
| </xsd:enumeration> |
WAV files are usually (if not always) uncompressed, so I would believe there would rarely be broadcasted, too.
| <xsd:enumeration value="audio/midi"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>MIDI audio file</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:enumeration> |
There was a problem hiding this comment.
| <xsd:enumeration value="audio/midi"> | |
| <xsd:annotation> | |
| <xsd:documentation>MIDI audio file</xsd:documentation> | |
| </xsd:annotation> | |
| </xsd:enumeration> |
I would remove this one. WDYT @Aurige ; if a prompt is supposed to be a message, MIDI is probably out of scope here.
| <xsd:enumeration value="audio/mp4"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>MP4 audio file</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:enumeration> |
There was a problem hiding this comment.
| <xsd:enumeration value="audio/mp4"> | |
| <xsd:annotation> | |
| <xsd:documentation>MP4 audio file</xsd:documentation> | |
| </xsd:annotation> | |
| </xsd:enumeration> | |
| <xsd:enumeration value="audio/mpeg"> | |
| <xsd:annotation> | |
| <xsd:documentation>MPEG audio file (e.g., mp3)</xsd:documentation> | |
| </xsd:annotation> | |
| </xsd:enumeration> | |
| <xsd:enumeration value="audio/mp4"> | |
| <xsd:annotation> | |
| <xsd:documentation>MP4 audio file</xsd:documentation> | |
| </xsd:annotation> | |
| </xsd:enumeration> |
| @@ -0,0 +1,126 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- (C) Copyright 2005-2012 CEN SIRI --> | |||
There was a problem hiding this comment.
| <!-- (C) Copyright 2005-2012 CEN SIRI --> | |
| <!-- (C) Copyright 2005-2026 CEN SIRI --> |
| @@ -0,0 +1,126 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- (C) Copyright 2005-2012 CEN SIRI --> | |||
| <Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd"> | |||
There was a problem hiding this comment.
| <Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd"> | |
| <Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.3.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd"> |
| <xsd:element name="Prompt" type="PromptType" minOccurs="0" maxOccurs="unbounded"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Display prompt for presenting action to user. (Unbounded since SIRI 2.0)</xsd:documentation> | ||
| <xsd:documentation>Display prompt for presenting action to user. (Unbounded since SIRI 2.0). Possibility to add attributs on the type of prompt, and its language (+v2.3)</xsd:documentation> |
There was a problem hiding this comment.
| <xsd:documentation>Display prompt for presenting action to user. (Unbounded since SIRI 2.0). Possibility to add attributs on the type of prompt, and its language (+v2.3)</xsd:documentation> | |
| <xsd:documentation>Display prompt for presenting action to user. (Unbounded since SIRI 2.0). Possibility to add attributes on the type of prompt, and its language (+v2.3)</xsd:documentation> |
| </xsd:element> | ||
| <xsd:element name="Url" type="ContentURI" minOccurs="0" maxOccurs="unbounded"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Direct link to the content to be published or broadcaseted as is (e.g., pre-recorded message, image, etc.).</xsd:documentation> |
There was a problem hiding this comment.
| <xsd:documentation>Direct link to the content to be published or broadcaseted as is (e.g., pre-recorded message, image, etc.).</xsd:documentation> | |
| <xsd:documentation>Direct link to the content to be published or broadcast as is (e.g., pre-recorded message, image, etc.).</xsd:documentation> |
| </xsd:complexType> | ||
| <xsd:simpleType name="ContentTypeEnumeration"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Allowed values for contenType attribute (+v2.3)</xsd:documentation> |
There was a problem hiding this comment.
| <xsd:documentation>Allowed values for contenType attribute (+v2.3)</xsd:documentation> | |
| <xsd:documentation>Allowed values for contentType attribute (+v2.3)</xsd:documentation> |
| <xsd:minInclusive value="0"/> | ||
| </xsd:restriction> | ||
| </xsd:simpleType> | ||
| <xsd:complexType name="PromptType"> |
There was a problem hiding this comment.
| <xsd:complexType name="PromptType"> | |
| <xsd:complexType name="PromptStructure"> |
I think that this would be more idiomatic re: existing use of complex types in SIRI (to be verified).
| </xsd:extension> | ||
| </xsd:simpleContent> | ||
| </xsd:complexType> | ||
| <xsd:complexType name="ContentURI"> |
There was a problem hiding this comment.
| <xsd:complexType name="ContentURI"> | |
| <xsd:complexType name="ContentUriStructure"> |
Promptto embed MIME content typeUrlwith a specific type to embed MIME content type and languageThis PR is to be discussed and merged before PR #210 that adds
PublishToAudioAction. To includeUrlinActionDataaddresses @skinkie comment