Skip to content

Allow CLI to use nodedb_type='rwdb' #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tequdev wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −10
Open

Allow CLI to use nodedb_type='rwdb' #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58d5402
Allow CLI to use nodedb_type='rwdb'
tequdev Mar 21, 2026
5282309
exclude path, advisory_delete, online_delete if node_type=rwdb
tequdev May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ xrpld-netgen create:network [OPTIONS]
- `--log_level` - Log level: "warning", "debug", "trace" (default: "trace")
- `--genesis` - Enable genesis mode (default: false)
- `--quorum` - Consensus quorum requirement (default: num_validators - 1)
- `--nodedb_type` - Database type: "Memory" or "NuDB" (default: "NuDB")
- `--nodedb_type` - Database type: "Memory" or "NuDB" or "rwdb" (default: "NuDB")
- `--local` - Create local network without Docker (runs natively)
- `--binary_name` - Custom xrpld binary name (default: "xrpld")
- `--build_server` - Build server URL (auto-detected by protocol)
Expand Down Expand Up @@ -189,7 +189,7 @@ xrpld-netgen up:local [OPTIONS]
- `--protocol` - Protocol: "xrpl" or "xahau" (default: "xahau")
- `--log_level` - Log level: "warning", "debug", "trace" (default: "trace")
- `--network_id` - Network identifier (default: 21339)
- `--nodedb_type` - Database type: "Memory" or "NuDB" (default: "NuDB")
- `--nodedb_type` - Database type: "Memory" or "NuDB" or "rwdb" (default: "NuDB")
- `--public_key` - Validator list public key
- `--import_key` - Import validator list key

Expand Down Expand Up @@ -233,7 +233,7 @@ xrpld-netgen up:standalone [OPTIONS]
- `--build_type` - Build type: "image" or "binary" (default: "binary")
- `--log_level` - Log level: "warning", "debug", "trace" (default: "trace")
- `--network_id` - Network identifier (default: 21339 for xahau, 1 for xrpl)
- `--nodedb_type` - Database type: "Memory" or "NuDB" (default: "NuDB")
- `--nodedb_type` - Database type: "Memory" or "NuDB" or "rwdb" (default: "NuDB")
- `--ipfs` - Include IPFS server in deployment (default: false)
- `--deploy` - Deploy as Docker image to registry (default: false)
- `--server` - Build server URL (optional)
Expand Down
6 changes: 3 additions & 3 deletions xrpld_netgen/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def main():
type=str,
required=False,
help="The node db",
choices=["Memory", "NuDB"],
choices=["Memory", "NuDB", "rwdb"],
default="NuDB",
)
# down:local
Expand Down Expand Up @@ -197,7 +197,7 @@ def main():
type=str,
required=False,
help="The node db for the network",
choices=["Memory", "NuDB"],
choices=["Memory", "NuDB", "rwdb"],
default="NuDB",
)
parser_cn.add_argument(
Expand Down Expand Up @@ -340,7 +340,7 @@ def main():
type=str,
required=False,
help="The node db",
choices=["Memory", "NuDB"],
choices=["Memory", "NuDB", "rwdb"],
default="NuDB",
)
# down:standalone
Expand Down
9 changes: 5 additions & 4 deletions xrpld_netgen/xrpld_cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,11 @@ def generate_xrpld_cfg(

cfg_out += "[node_db]" + "\n"
cfg_out += f"type={nodedb_type}" + "\n"
cfg_out += f"path={nodedb_path}" + "\n"
if num_ledgers:
cfg_out += "advisory_delete=0" + "\n"
cfg_out += f"online_delete={num_ledgers}" + "\n"
if nodedb_type != "rwdb":
cfg_out += f"path={nodedb_path}" + "\n"
if num_ledgers:
cfg_out += "advisory_delete=0" + "\n"
cfg_out += f"online_delete={num_ledgers}" + "\n"
cfg_out += "\n"

if relational_db:
Expand Down