VOICEVOX資産のstaging配信先の手順を設計書に追記 - #6932
Closed
TinyKitten wants to merge 1 commit into
Closed
TinyKitten wants to merge 1 commit into
TinyKitten wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tVYs6Yu7jchkzxe6hAG2t
Contributor
|
Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 52 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Comment |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
#6931 のうち、ドキュメントの追記のみを行う。VOICEVOX 資産の staging 配信先(R2 バケット
trainlcd-assets-dev/ ホストassets-stg.trainlcd.app)への公開手順を、オンデバイス TTS 設計書に追加した。Cloudflare 側の実作業(バケット作成・独自ドメインの紐付け・staging への公開)と dev
CONFIG_KVへのvoicevox_tts_manifest_url_ios追加はこのPRには含まれない。詳細は下の「残作業」を参照。変更の種類
変更内容
docs/spec/tts/on-device-tts-ios.mdに「staging 配信先」節を追加CONFIG_KVの対応表-dev、ホストが-stgと揃っていない理由(既存の命名の混在に合わせた意図的な選択であること)VOICEVOX_R2_BUCKET/VOICEVOX_ASSETS_HOSTを渡してscripts/publish-voicevox-assets.mjsを実行する手順。バケット作成とドメイン紐付けも同じ実行に含まれるvoicevox_tts_manifest_url_iosだけを staging に向け、production は据え置くという運用アプリ側のコード変更は無い(#6931 の想定どおり)。
残作業(このPRの範囲外)
trainlcd-assets-devの作成とassets-stg.trainlcd.appの紐付けCONFIG_KVのconfig:remoteにvoicevox_tts_manifest_url_ios = https://assets-stg.trainlcd.app/voicevox/manifest.jsonを追加(functions リポジトリ側)テスト
npm run lintが通ることnpm testが通ることnpm run typecheckが通ること省略:
docs/**のみの変更でアプリのコードに変更が無いため。markdownlint-cli2は追加箇所について MD013(line-length)以外の指摘なしを確認した(MD013 はこのファイルの既存行にも出ており、リポジトリで運用していない)。関連Issue
Refs #6931
Issue の 4 項目のうちドキュメント(項目 4)だけを満たすため、
ClosesではなくRefsにしている。スクリーンショット(任意)
UI 変更なし:
docs/**のみの変更で、アプリの画面には影響しません。🤖 Generated with Claude Code
https://claude.ai/code/session_011tVYs6Yu7jchkzxe6hAG2t