Fix build that broke with 77 removal and make sync curation + build more robust - #357
Merged
Merged
Conversation
- Update synchronization to remove stale empty assignments for deleted cards. - Improve validation to handle stale empty assignments and provide warnings. - Add tests for synchronization behavior and validation rules regarding empty assignments.
|
| Severity | Affected path | Rule | Message |
|---|---|---|---|
documentation/curating-program-card-index.md |
change-outside-release-directory |
Card submissions must not include changes outside releases/<card>/ directories. | |
tools/sitegen/package-lock.json |
change-outside-release-directory |
Card submissions must not include changes outside releases/<card>/ directories. | |
tools/sitegen/src/curation/cli.js |
change-outside-release-directory |
Card submissions must not include changes outside releases/<card>/ directories. | |
tools/sitegen/src/curation/flairs.yml |
change-outside-release-directory |
Card submissions must not include changes outside releases/<card>/ directories. | |
tools/sitegen/src/validate/prRules.js |
change-outside-release-directory |
Card submissions must not include changes outside releases/<card>/ directories. | |
tools/sitegen/test/curation-cli.test.js |
change-outside-release-directory |
Card submissions must not include changes outside releases/<card>/ directories. | |
tools/sitegen/test/pr-rules.test.js |
change-outside-release-directory |
Card submissions must not include changes outside releases/<card>/ directories. |
philmillman
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the curation workflow for program cards to automatically remove empty assignments for deleted cards, while ensuring that assignments with editorial flairs are preserved for manual review. It updates documentation, validation logic, synchronization behavior, and PR rule checks to reflect these changes, and adds new tests to verify the revised logic.
Curation workflow improvements:
Documentation updates:
PR rules and automation:
flairs.ymlnow supports both adding missing empty assignments and removing empty assignments for deleted cards, and tests have been added to verify this. [1] [2]Codebase and test enhancements:
validateandsynchronizefunctions are now exported for testing, and new tests cover the updated validation and synchronization logic. [1] [2]nanoiddependency is updated from version 3.3.16 to 3.3.18.Curation data update:
77_Placeholder) was removed fromflairs.yml.