feat(keys): import API keys into TF CLI from the Keys page - #1956
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#tfcli=URL fragment namespace before initial release. The companion tf-cli implementation is ed4df86, with the namespace finalized in 2548c36. There is deliberately no legacy#tf=parser because the integration has not shipped.tfprocess on exact loopback ports43110through43119. The TokenRouter backend provides no import or authorization endpoint, and keys never transit the TokenRouter backend./keys#tfcli=1.<port>.<secret>session links. The router removes every#tfcli=fragment immediately before auth redirects, and valid sessions remain in module memory for up to 10 minutes.group_idandgroup_name; composite keys omit single source group fields.tf.Security and compatibility
connect-srcexplicitly permitshttp://127.0.0.1:43110throughhttp://127.0.0.1:43119, with no wildcard ports or LAN expansion.tfsession secret and request integrity. It provides no page, key, local binary, or gateway authentication, freshness guarantee, or replay protection./pingand/import, requiring an explicit browser warning and a second confirmation. Terminal confirmation is mandatory in all paths.Validation
make check,go test -race ./..., PTY tests (9/9), and cross-compilation across five targets passed.vue-tsc; and production build passed.go test ./...passed on the final feature baseline; the fragment rename itself added no backend changes.6c60a01e5.git diff --checkand forbidden-path checks passed.tfchecks confirmed#tfcli=generation and immediate URL removal, the proof header, an emptyReferer, terminal confirmation, truthful HTTP 202 UI state, exit 0, and isolated0600credential persistence.