Skip to content

Port to Minecraft 26.1.2 (first Mojang-mapped release)#44

Merged
ToCraft merged 14 commits into
ToCraft:devfrom
tgboyles:main
May 10, 2026
Merged

Port to Minecraft 26.1.2 (first Mojang-mapped release)#44
ToCraft merged 14 commits into
ToCraft:devfrom
tgboyles:main

Conversation

@tgboyles
Copy link
Copy Markdown

@tgboyles tgboyles commented May 3, 2026

Summary

  • Ports CraftedCore to Minecraft 26.1.2, the first Mojang-mapped (unobfuscated) release
  • Updates ResourceKey.location().identifier() and other renamed API calls
  • Replaces CommandSourceStack.hasPermission(int) with Commands.hasPermission(Commands.LEVEL_GAMEMASTERS) (permission int API removed)
  • Registers KeyMapping.Category via KeyMapping.Category.register(Identifier) instead of a plain String
  • Updates NeoForge: FMLEnvironment.dist field → FMLEnvironment.getDist() method
  • Fixes maven artifact IDs to match expected craftedcore / craftedcore-fabric / craftedcore-neoforge coordinates

Test plan

  • ./gradlew publishToMavenLocal completes without errors
  • Woodwalkers mod builds successfully against this published artifact
  • Game launches on both Fabric and NeoForge without mixin failures

🤖 Generated with Claude Code

thomas and others added 3 commits May 2, 2026 10:37
Full port of craftedcore to Minecraft Java Edition 26.1.2 targeting
Fabric API 0.147.0 and NeoForge 26.1.2.36-beta. See README for a
complete breakdown of API renames and build changes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ic/craftedcore-neoforge

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tgboyles
Copy link
Copy Markdown
Author

tgboyles commented May 3, 2026

Dear @ToCraft,

My daughter is a serious Minecraft enthusiast and has been begging me to figure out how to let us 'play together as wolves'. Your mod system appears to be the best version of this request, but it wasn't compatible with the latest Java version. We spent the day porting this project and woodwalker-mod (ToCraft/woodwalkers-mod#233) to 26.1.2 and I wanted to open a couple PRs for the changes in case you were interested in the updates. Either way, thank you for doing these projects. You've already brought her significant joy and given me an opportunity to explain a ton of important software engineering concepts. Cheers,

Thomas

- Add check.yml: PR builds for fabric and neoforge
- Replace modmaster release action with GitHub Releases; tags on version bump
- Name JARs craftedcore-fabric/neoforge-{version}.jar via archivesName
- Bump version to 8.0-tgboyles_1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Owner

@ToCraft ToCraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! First of all, thank you for your work! It really helps me a lot!

I just had the time to do small tests and to look at your code - I noticed you switch to a manual setup of fabric loom and neoforged moddev. Was there a problem with Architectury Loom in your runs? (My custom Gradle Plugin is based on Architectury Loom).

In my tests, I noticed that the Living Breath Event didn't work for NeoForge. Everything else in my testing worked. Could you fix it, please?

Another thing I noticed is a NeoForge warning on startup informing that the @OnlyIn annotations are no longer functional. I think it would be best to remove them before compiling.

The fabric tests went just fine 😄 .

I already updated the gradle wrapper and added runs to neoforge in your branch, I hope that's ok for you.

Currently, I don't have much time for coding, but I'll have time next week. I'll take a look at your PR in the woodwalkers repository then.

If you like, I'll add you and your daughter to the list of developers (you probably already noticed it in the main class of Woodwalkers). It will unlock you both a special wolf texture as a thank you.
I'll need your Minecraft Usernames or your UUIDs for the list (or you can add them yourself in your Pull Request).

@ToCraft ToCraft changed the base branch from main to dev May 7, 2026 16:23
@ToCraft
Copy link
Copy Markdown
Owner

ToCraft commented May 9, 2026

Hey, just so you know - I merged your new gradle code with my modmaster gradle plugin in order to cleanup the files. I also fixed the testmod projects.

@ToCraft
Copy link
Copy Markdown
Owner

ToCraft commented May 10, 2026

Hey, I found out, why the Living Breathe event did not work for NeoForge - they commented it: https://github.com/neoforged/NeoForge/blame/cae9f23d665ac0d8696811c94dd0c9196770f662/src/main/java/net/neoforged/neoforge/common/CommonHooks.java#L1420

So, I added a mixin for NeoForge, which reimplements the Living Breathe event. I will remove the @OnlyIn annotations myself and, therefore, merge this PR now. Probably, I'll change a thing or two before I publish it as a release. But again, thank you very much for the Pull Request!
We can now focus on the PR for the woodwalkers mod.

@ToCraft ToCraft merged commit 30b42d6 into ToCraft:dev May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants