Port to Minecraft 26.1.2 (first Mojang-mapped release)#44
Conversation
Full port of craftedcore to Minecraft Java Edition 26.1.2 targeting Fabric API 0.147.0 and NeoForge 26.1.2.36-beta. See README for a complete breakdown of API renames and build changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ic/craftedcore-neoforge Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Dear @ToCraft, My daughter is a serious Minecraft enthusiast and has been begging me to figure out how to let us 'play together as wolves'. Your mod system appears to be the best version of this request, but it wasn't compatible with the latest Java version. We spent the day porting this project and woodwalker-mod (ToCraft/woodwalkers-mod#233) to 26.1.2 and I wanted to open a couple PRs for the changes in case you were interested in the updates. Either way, thank you for doing these projects. You've already brought her significant joy and given me an opportunity to explain a ton of important software engineering concepts. Cheers, Thomas |
- Add check.yml: PR builds for fabric and neoforge
- Replace modmaster release action with GitHub Releases; tags on version bump
- Name JARs craftedcore-fabric/neoforge-{version}.jar via archivesName
- Bump version to 8.0-tgboyles_1
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Hey! First of all, thank you for your work! It really helps me a lot!
I just had the time to do small tests and to look at your code - I noticed you switch to a manual setup of fabric loom and neoforged moddev. Was there a problem with Architectury Loom in your runs? (My custom Gradle Plugin is based on Architectury Loom).
In my tests, I noticed that the Living Breath Event didn't work for NeoForge. Everything else in my testing worked. Could you fix it, please?
Another thing I noticed is a NeoForge warning on startup informing that the @OnlyIn annotations are no longer functional. I think it would be best to remove them before compiling.
The fabric tests went just fine 😄 .
I already updated the gradle wrapper and added runs to neoforge in your branch, I hope that's ok for you.
Currently, I don't have much time for coding, but I'll have time next week. I'll take a look at your PR in the woodwalkers repository then.
If you like, I'll add you and your daughter to the list of developers (you probably already noticed it in the main class of Woodwalkers). It will unlock you both a special wolf texture as a thank you.
I'll need your Minecraft Usernames or your UUIDs for the list (or you can add them yourself in your Pull Request).
|
Hey, just so you know - I merged your new gradle code with my modmaster gradle plugin in order to cleanup the files. I also fixed the testmod projects. |
|
Hey, I found out, why the Living Breathe event did not work for NeoForge - they commented it: https://github.com/neoforged/NeoForge/blame/cae9f23d665ac0d8696811c94dd0c9196770f662/src/main/java/net/neoforged/neoforge/common/CommonHooks.java#L1420 So, I added a mixin for NeoForge, which reimplements the Living Breathe event. I will remove the |
Summary
ResourceKey.location()→.identifier()and other renamed API callsCommandSourceStack.hasPermission(int)withCommands.hasPermission(Commands.LEVEL_GAMEMASTERS)(permission int API removed)KeyMapping.CategoryviaKeyMapping.Category.register(Identifier)instead of a plainStringFMLEnvironment.distfield →FMLEnvironment.getDist()methodcraftedcore/craftedcore-fabric/craftedcore-neoforgecoordinatesTest plan
./gradlew publishToMavenLocalcompletes without errors🤖 Generated with Claude Code